From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 7/17] jffs2: convert jffs2_gc_fetch_page to
	read_cache_page
Date: Sun, 15 Apr 2007 11:52:47 +0100
Message-ID: <1176634367.7929.63.camel@pmac.infradead.org>
References: <20070412024938.27380.13619.patchbomb.py@localhost>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: Andrew Morton <akpm@osdl.org>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Christoph Hellwig <hch@infradead.org>,
	Roman Zippel <zippel@linux-m68k.org>,
	Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>,
	Dave Kleikamp <shaggy@austin.ibm.com>,
	Anton Altaparmakov <aia21@cantab.net>,
	Evgeniy Dushistov <dushistov@mail.ru>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	reiserfs-dev@namesys.com
To: Nate Diller <nate.diller@gmail.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from canuck.infradead.org ([209.217.80.40]:34095 "EHLO
	canuck.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752204AbXDOKxM (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Sun, 15 Apr 2007 06:53:12 -0400
In-Reply-To: <20070412024938.27380.13619.patchbomb.py@localhost>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Wed, 2007-04-11 at 19:49 -0700, Nate Diller wrote:
> Replace jffs2_gc_fetch_page() and jffs2_gc_release_page() using the
> read_cache_page() and put_kmapped_page() calls, and update the call site
> accordingly.  Explicit calls to kmap()/kunmap() make the code more clear.
> 
> Signed-off-by: Nate Diller <nate.diller@gmail.com> 

Please don't remove the jffs2_gc_{fetch,release}_page functions. The
reason they're in a separate file is because that file (fs.c) is built
on Linux only, while the file you're moving the code into (gc.c) is
OS-agnostic; it's used on other sytems (eCos) too.

Rather than forcing eCos and any other systems which have a JFFS2 port
to implement a crappy Linux 'emulation' layer, I try to keep the
Linuxisms localised to certain files which can be completely
reimplemented for a non-Linux port.

-- 
dwmw2