Re: [patch 0/8] unprivileged mount syscall

Miklos Szeredi
2007-04-07T06:41:48Z

> > This patchset adds support for keeping mount ownership information in
> > the kernel, and allow unprivileged mount(2) and umount(2) in certain
> > cases.
>
> No replies, huh?

All we need is a comment from Andrew, and the replies come flooding in ;)

> My knowledge of the code which you're touching is not strong, and my spare
> reviewing capacity is not high. And this work does need close review by
> people who are familar with the code which you're changing.
>
> So could I suggest that you go for a dig through the git history, identify
> some individuals who look like they know this code, then do a resend,
> cc'ing those people? Please also cc linux-kernel on that resend.

OK.

> > One thing that is missing from this series is the ability to restrict
> > user mounts to private namespaces. The reason is that private
> > namespaces have still not gained the momentum and support needed for
> > painless user experience. So such a feature would not yet get enough
> > attention and testing. However adding such an optional restriction
> > can be done with minimal changes in the future, once private
> > namespaces have matured.
>
> I suspect the people who developed and maintain nsproxy would disagree ;)

Well, they better show me some working and simple-to-use userspace
code, because I've not seen anything like that related to mount
namespaces.

pam_namespace.so is one example of a non-working, but probably-not-too-
hard-to-fix one.

I'm just saying this is not yet something that Joe Blow would just
enable by ticking a box in their desktop setup wizard, and it would
all work flawlessly thereafter. There's still a _long_ way towards
that, and mostly in userspace.

Thanks,
Miklos