[GIT PULL -mm] Unionfs updates

[GIT PULL -mm] Unionfs updates

[Josef 'Jeff' Sipek]

The following patches (also available though the git tree) fix few small
bugs in Unionfs.

You can pull from 'master' branch of
git://git.kernel.org/pub/scm/linux/kernel/git/jsipek/unionfs.git

to receive the following:

Adrian Brunyate (2):
      Unionfs: Accept MS_SILENT during remount
      Unionfs: Check remount options for being NULL

Adrian Bunk (1):
      fix unionfs compilation

 fs/unionfs/super.c |   17 +++++++++--------
 1 files changed, 9 insertions(+), 8 deletions(-)

Josef 'Jeff' Sipek.

jsipek@cs.sunysb.edu

[PATCH 1/3] Unionfs: Accept MS_SILENT during remount

[Josef 'Jeff' Sipek]

From: Adrian Brunyate <abrunyate@yahoo.com>

[jsipek: whitespace cleanup]
Signed-off-by: Adrian Brunyate <abrunyate@yahoo.com>
Signed-off-by: Josef 'Jeff' Sipek <jsipek@cs.sunysb.edu>
---
 fs/unionfs/super.c |   12 +++++++-----
 1 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/fs/unionfs/super.c b/fs/unionfs/super.c
index e6a6cc1..ee12d03 100644
--- a/fs/unionfs/super.c
+++ b/fs/unionfs/super.c
@@ -425,11 +425,12 @@ static int unionfs_remount_fs(struct super_block *sb, int *flags,
 	unionfs_write_lock(sb);
 
 	/*
-	 * The VFS will take care of "ro" and "rw" flags, so anything else
-	 * is an error.  So we need to check if any other flags may have
-	 * been passed (none are allowed/supported as of now).
+	 * The VFS will take care of "ro" and "rw" flags, and we can safely
+	 * ignore MS_SILENT, but anything else left over is an error.  So we
+	 * need to check if any other flags may have been passed (none are
+	 * allowed/supported as of now).
 	 */
-	if ((*flags & ~MS_RDONLY) != 0) {
+	if ((*flags & ~(MS_RDONLY | MS_SILENT)) != 0) {
 		printk(KERN_WARNING
 		       "unionfs: remount flags 0x%x unsupported\n", *flags);
 		err = -EINVAL;
@@ -731,7 +732,8 @@ out_no_change:
 	i = atomic_inc_return(&UNIONFS_SB(sb)->generation);
 	atomic_set(&UNIONFS_D(sb->s_root)->generation, i);
 	atomic_set(&UNIONFS_I(sb->s_root->d_inode)->generation, i);
-	printk("unionfs: new generation number %d\n", i);
+	if (!(*flags & MS_SILENT)) 
+		printk("unionfs: new generation number %d\n", i);
 	err = 0;		/* reset to success */
 
 	/*
-- 
1.5.0.3.1043.g4342

[PATCH 2/3] Unionfs: Check remount options for being NULL

[Josef 'Jeff' Sipek]

From: Adrian Brunyate <abrunyate@yahoo.com>

Signed-off-by: Adrian Brunyate <abrunyate@yahoo.com>
Signed-off-by: Josef 'Jeff' Sipek <jsipek@cs.sunysb.edu>
---
 fs/unionfs/super.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/unionfs/super.c b/fs/unionfs/super.c
index ee12d03..02c0cc8 100644
--- a/fs/unionfs/super.c
+++ b/fs/unionfs/super.c
@@ -442,7 +442,7 @@ static int unionfs_remount_fs(struct super_block *sb, int *flags,
 	 * the union to a "ro" or "rw" and the VFS took care of it.  So
 	 * nothing to do and we're done.
 	 */
-	if (options[0] == '\0')
+	if (!options || options[0] == '\0')
 		goto out_error;
 
 	/*
-- 
1.5.0.3.1043.g4342

[PATCH 3/3] [PATCH] fix unionfs compilation

[Josef 'Jeff' Sipek]

From: Adrian Bunk <bunk@stusta.de>

On Sat, May 05, 2007 at 01:49:55AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.21-rc7-mm2:
>...
>  git-unionfs.patch
>...
>  git trees
>...

<--  snip  -->

...
  CC      fs/unionfs/super.o
/home/bunk/linux/kernel-2.6/linux-2.6.21-mm1/fs/unionfs/super.c: In function ‘init_once’:
/home/bunk/linux/kernel-2.6/linux-2.6.21-mm1/fs/unionfs/super.c:822: error: ‘SLAB_CTOR_VERIFY’ undeclared (first use in this function)
/home/bunk/linux/kernel-2.6/linux-2.6.21-mm1/fs/unionfs/super.c:822: error: (Each undeclared identifier is reported only once
/home/bunk/linux/kernel-2.6/linux-2.6.21-mm1/fs/unionfs/super.c:822: error: for each function it appears in.)
make[3]: *** [fs/unionfs/super.o] Error 1

<--  snip  -->

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Josef 'Jeff' Sipek <jsipek@cs.sunysb.edu>
---
 fs/unionfs/super.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/fs/unionfs/super.c b/fs/unionfs/super.c
index 02c0cc8..af5a1c5 100644
--- a/fs/unionfs/super.c
+++ b/fs/unionfs/super.c
@@ -821,8 +821,7 @@ static void init_once(void *v, struct kmem_cache * cachep, unsigned long flags)
 {
 	struct unionfs_inode_info *i = v;
 
-	if ((flags & (SLAB_CTOR_VERIFY | SLAB_CTOR_CONSTRUCTOR)) ==
-	    SLAB_CTOR_CONSTRUCTOR)
+	if (flags & SLAB_CTOR_CONSTRUCTOR)
 		inode_init_once(&i->vfs_inode);
 }
 
-- 
1.5.0.3.1043.g4342

-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[GIT PULL -mm] Unionfs updates

[Josef 'Jeff' Sipek]

The following patches (also available though the git tree) address a number
of code issues with Unionfs. (Sorry if you got duplicates, I forgot to CC
fsdevel.)

You can pull from 'master' branch of
git://git.kernel.org/pub/scm/linux/kernel/git/jsipek/unionfs.git

to receive the following:

Erez Zadok (6):
      fs/unionfs: Fix a memory leak & null pointer dereference
      fs/unionfs/: Fix a memory leak in unionfs_read_super
      fs/unionfs/: Fix copyup_deleted_file dentry leak
      fs/unionfs/: mntput in __cleanup_dentry
      fs/unionfs/: Fix dentry leak in copyup_named_dentry
      fs/unionfs/: Fix unlocking in error paths

Josef 'Jeff' Sipek (7):
      fs/unionfs/: Don't grab dentry private data mutex in unionfs_d_release
      fs/unionfs/: Several small cleanups in unionfs_interpose
      fs/unionfs/: Rename unionfs_d_revalidate_wrap
      fs/unionfs/: Remove alloc_filldir_node
      fs/unionfs/: Use SEEK_{SET,CUR} instead of hardcoded values
      fs/unionfs/: Check return value of d_path
      fs/unionfs/: Miscellaneous coding style fixes

 fs/unionfs/commonfops.c |   22 ++++++++++++++++++----
 fs/unionfs/copyup.c     |   17 +++++++++++++----
 fs/unionfs/dentry.c     |   15 ++++-----------
 fs/unionfs/dirfops.c    |    6 +++---
 fs/unionfs/lookup.c     |   11 +++++++++--
 fs/unionfs/main.c       |   18 ++++++------------
 fs/unionfs/rdstate.c    |    8 +-------
 fs/unionfs/super.c      |    8 ++++++--
 fs/unionfs/union.h      |    2 +-
 9 files changed, 61 insertions(+), 46 deletions(-)

Josef 'Jeff' Sipek.

jsipek@cs.sunysb.edu