From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 1/2] LogFS proper
Date: Tue, 08 May 2007 17:54:41 +0200
Message-ID: <1178639681.3042.334.camel@localhost.localdomain>
References: <20070507215913.GA15054@lazybastard.org>
	 <20070507220036.GB15054@lazybastard.org>
	 <1178608950.3042.273.camel@localhost.localdomain>
	 <Pine.LNX.4.61.0705081439270.17280@yvahk01.tjqt.qr>
Reply-To: tglx@linutronix.de
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: =?ISO-8859-1?Q?J=F6rn?= Engel <joern@lazybastard.org>,
	Andrew Morton <akpm@osdl.org>, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Dave Kleikamp <shaggy@linux.vnet.ibm.com>,
	David Chinner <dgc@sgi.com>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from www.osadl.org ([213.239.205.134]:39596 "EHLO mail.tglx.de"
	rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
	id S967613AbXEHPv6 (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 8 May 2007 11:51:58 -0400
In-Reply-To: <Pine.LNX.4.61.0705081439270.17280@yvahk01.tjqt.qr>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Tue, 2007-05-08 at 14:46 +0200, Jan Engelhardt wrote:
> >> +static int __logfs_readdir(struct file *file, void *buf, filldir_t filldir)
> >> +{
> >> +		err = read_dir(dir, &dd, pos);
> >> +		if (err == -EOF)
> >> +			break;
> >
> >	-EOF results in a return code 0 ?
> 
> Results in a return code -256.

Really ? It breaks out of the loop and returns 0 !

> +	}
> +
> +	file->f_pos = pos + IMPLICIT_NODES;
> +	return 0;

	tglx