From: Vladis Dronov <vdronov@redhat.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] debugfs: Fix module state check condition
Date: Mon, 7 Sep 2020 07:47:47 -0400 (EDT) [thread overview]
Message-ID: <1180880820.16044889.1599479267134.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20200904161240.GA3730201@kroah.com>
Hello, Greg,
----- Original Message -----
> From: "Greg KH" <gregkh@linuxfoundation.org>
> Subject: Re: [PATCH] debugfs: Fix module state check condition
>
...skip...
> > A customer which has reported this issue replied with a test result:
> >
> > > I ran the same test.
> > > Started ib_write_bw traffic and started watch command to read RoCE
> > > stats : watch -d -n 1 "cat /sys/kernel/debug/bnxt_re/bnxt_re0/info".
> > > While the command is running, unloaded roce driver and I did not
> > > observe the call trace that was seen earlier.
>
> Having this info, that this was affecting a user, would have been good
> in the original changelog info, otherwise this just looked like a code
> cleanup patch to me.
Thank you, Greg. Makes sense indeed, I will pay attention to this next time(s).
<rant>oh so many little but important details to know and follow...</rant>
> I'll go queue this up now, thanks.
>
> greg k-h
Best regards,
Vladis Dronov | Red Hat, Inc. | The Core Kernel | Senior Software Engineer
prev parent reply other threads:[~2020-09-07 11:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 15:01 [PATCH] debugfs: Fix module state check condition Vladis Dronov
2020-09-04 11:42 ` Vladis Dronov
2020-09-04 11:50 ` Greg KH
2020-09-04 11:58 ` Vladis Dronov
2020-09-04 16:12 ` Greg KH
2020-09-07 11:47 ` Vladis Dronov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1180880820.16044889.1599479267134.JavaMail.zimbra@redhat.com \
--to=vdronov@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).