From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Woodhouse Subject: Re: [Patch 04/18] include/linux/logfs.h Date: Tue, 05 Jun 2007 16:53:55 +0100 Message-ID: <1181058836.16089.23.camel@hades.cambridge.redhat.com> References: <20070603183845.GA8952@lazybastard.org> <20070603184205.GE8952@lazybastard.org> <200706032342.27252.arnd@arndb.de> <20070604091245.GF14823@lazybastard.org> <1180964303.25232.358.camel@pmac.infradead.org> <18f622d94e9273fe6c93ef091fcec87c@kernel.crashing.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Kyle Moffett , John Stoffel , Willy Tarreau , Evgeniy Polyakov , CaT , Ondrej Zajicek , linux-kernel@vger.kernel.org, Bill Davidsen , Jan Engelhardt , Thomas Gleixner , Dongjun Shin , Pekka Enberg , Arnd Bergmann , Albert Cahalan , linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org, Artem Bityutskiy , Sam Ravnborg , Jamie Lokier , Roland Dreier , =?ISO-8859-1?Q?J=F6rn?= Engel , Pavel Machek , Ulisses Furquim , akpm@osdl.org, David Weinehall To: Segher Boessenkool Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:36450 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932426AbXFEPyq (ORCPT ); Tue, 5 Jun 2007 11:54:46 -0400 In-Reply-To: <18f622d94e9273fe6c93ef091fcec87c@kernel.crashing.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, 2007-06-05 at 17:49 +0200, Segher Boessenkool wrote: > > It would be better if GCC had a 'nopadding' attribute which gave us > > what we need without the _extra_ implications about alignment. > > That's impossible; removing the padding from a struct > _will_ make accesses to its members unaligned (think > about arrays of that struct). It _might_ make accesses to _some_ of its members unaligned. That's why I said 'without the __EXTRA__ implications about alignment'. Obviously the lack of padding has its own implications, but we don't necessarily need to assume that the struct may be at arbitrary locations. -- dwmw2