From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Whitehouse Subject: Re: [PATCH 4/5] gfs2: stop giving out non-cluster-coherent leases Date: Mon, 11 Jun 2007 10:38:18 +0100 Message-ID: <1181554698.25918.300.camel@quoit> References: Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: "J. Bruce Fields" , linux-fsdevel@vger.kernel.org, nfs@lists.sourceforge.net, Robert Rappaport , David Teigland , Trond Myklebust To: Marc Eshel Return-path: Received: from mx1.redhat.com ([66.187.233.31]:59314 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752106AbXFKJlU (ORCPT ); Mon, 11 Jun 2007 05:41:20 -0400 In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Hi, On Sat, 2007-06-09 at 09:35 -0700, Marc Eshel wrote: > This is the return code that setlease() currently returns when the lease > can not be obtained. Although ENOTSUPP would be more accurately describing > the error it will be a new return code from setlease() that is currently > not expected by callers to setlease(), but either return code should work. > Marc. > I prefer EOPNOTSUPP as it more accurately describes whats going on here. EAGAIN seems to me to imply that its something thats blocking temporarily and that trying again at a later time might result in success, Steve.