From mboxrd@z Thu Jan 1 00:00:00 1970 From: Trond Myklebust Subject: Re: [PATCH] NFS: Make NFS root work again Date: Sat, 16 Jun 2007 12:47:30 -0400 Message-ID: <1182012450.26143.8.camel@heimdal.trondhjem.org> References: <20070607164003.24322.51086.stgit@warthog.cambridge.redhat.com> <20070616091514.8e5dc1d3.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: David Howells , torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Andrew Morton Return-path: Received: from pat.uio.no ([129.240.10.15]:56924 "EHLO pat.uio.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754474AbXFPQrh (ORCPT ); Sat, 16 Jun 2007 12:47:37 -0400 In-Reply-To: <20070616091514.8e5dc1d3.akpm@linux-foundation.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Sat, 2007-06-16 at 09:15 -0700, Andrew Morton wrote: > On Thu, 07 Jun 2007 17:40:03 +0100 David Howells wrote: > > > Make NFS root work by creating a "/root" directory to satisfy the mount, > > otherwise the path lookup for the mount fails with ENOENT. > > > > Signed-off-by: David Howells > > --- > > > > init/do_mounts.c | 5 ++++- > > 1 files changed, 4 insertions(+), 1 deletions(-) > > > > diff --git a/init/do_mounts.c b/init/do_mounts.c > > index 46fe407..967b852 100644 > > --- a/init/do_mounts.c > > +++ b/init/do_mounts.c > > @@ -270,7 +270,10 @@ static void __init get_fs_names(char *page) > > > > static int __init do_mount_root(char *name, char *fs, int flags, void *data) > > { > > - int err = sys_mount(name, "/root", fs, flags, data); > > + int err; > > + > > + sys_mkdir("/root", 0755); > > + err = sys_mount(name, "/root", fs, flags, data); > > if (err) > > return err; > > Am still awaiting a proper description of this patch, please. > > What is not working, and how does this patch fix it? > > I am unaware of any open bug reports against NFS root. I'm confused too. We never used to require that the kernel create a special /root directory. What changed, and when? Trond