From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Hansen Subject: Re: [PATCH 14/26] elevate write count for file_update_time() Date: Mon, 25 Jun 2007 11:32:08 -0700 Message-ID: <1182796328.1387.11.camel@localhost> References: <20070622200303.82D9CC3A@kernel> <20070622200321.1D813C8A@kernel> <20070623074636.GK27954@infradead.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: akpm@osdl.org, linux-fsdevel@vger.kernel.org, viro@ftp.linux.org.uk To: Christoph Hellwig Return-path: Received: from e31.co.us.ibm.com ([32.97.110.149]:53061 "EHLO e31.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751403AbXFYScM (ORCPT ); Mon, 25 Jun 2007 14:32:12 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e31.co.us.ibm.com (8.13.8/8.13.8) with ESMTP id l5PIWCek010368 for ; Mon, 25 Jun 2007 14:32:12 -0400 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l5PIWAQX238304 for ; Mon, 25 Jun 2007 12:32:11 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l5PIWAvZ008395 for ; Mon, 25 Jun 2007 12:32:10 -0600 In-Reply-To: <20070623074636.GK27954@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Sat, 2007-06-23 at 08:46 +0100, Christoph Hellwig wrote: > On Fri, Jun 22, 2007 at 01:03:21PM -0700, Dave Hansen wrote: > > Signed-off-by: Dave Hansen > > We really want a guaranteed non-NULL file here, but I don't want to put > this on your plate also. Please add a comment about bloody NFS exports > for now. How does this look? - if (IS_RDONLY(inode)) + /* + * Ideally, we want to guarantee that 'f_vfsmnt' + * is non-NULL here. But, NFS exports need to + * be fixed up before we can do that. So, check + * it for now. - Dave Hansen + */ + if (file->f_vfsmnt) + err = mnt_want_write(file->f_vfsmnt); + if (err) return; -- Dave