From: "Josef 'Jeff' Sipek" <jsipek@cs.sunysb.edu>
To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Cc: akpm@linux-foundation.org, "Josef 'Jeff' Sipek" <jsipek@cs.sunysb.edu>
Subject: [PATCH 2/5] Unionfs: Add missing unlock call in unionfs_file_release
Date: Fri, 29 Jun 2007 03:26:18 -0400 [thread overview]
Message-ID: <1183101982279-git-send-email-jsipek@cs.sunysb.edu> (raw)
In-Reply-To: <1183101981740-git-send-email-jsipek@cs.sunysb.edu>
Signed-off-by: Josef 'Jeff' Sipek <jsipek@cs.sunysb.edu>
---
fs/unionfs/commonfops.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/unionfs/commonfops.c b/fs/unionfs/commonfops.c
index 6d87426..8527ac6 100644
--- a/fs/unionfs/commonfops.c
+++ b/fs/unionfs/commonfops.c
@@ -559,7 +559,7 @@ int unionfs_file_release(struct inode *inode, struct file *file)
* support.
*/
if ((err = unionfs_file_revalidate(file, 1)))
- return err;
+ goto out;
fileinfo = UNIONFS_F(file);
BUG_ON(file->f_dentry->d_inode != inode);
inodeinfo = UNIONFS_I(inode);
@@ -596,7 +596,9 @@ int unionfs_file_release(struct inode *inode, struct file *file)
fileinfo->rdstate = NULL;
}
kfree(fileinfo);
- return 0;
+out:
+ unionfs_read_unlock(sb);
+ return err;
}
/* pass the ioctl to the lower fs */
--
1.5.2.2.238.g7cbf2f2
next prev parent reply other threads:[~2007-06-29 7:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-29 7:26 [GIT PULL -mm] Unionfs cleanups and fixes Josef 'Jeff' Sipek
2007-06-29 7:26 ` [PATCH 1/5] Unionfs: Convert all instances of "hidden" to "lower" Josef 'Jeff' Sipek
2007-06-29 7:26 ` Josef 'Jeff' Sipek [this message]
2007-06-29 7:26 ` [PATCH 3/5] Unionfs: Use file->f_path instead of file->f_dentry Josef 'Jeff' Sipek
2007-06-29 7:26 ` [PATCH 4/5] Unionfs: Clarification comment for unionfs_lookup Josef 'Jeff' Sipek
2007-06-29 7:26 ` [PATCH 5/5] Unionfs: Remove unnecessary BUG_ON in unionfs_follow_link Josef 'Jeff' Sipek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1183101982279-git-send-email-jsipek@cs.sunysb.edu \
--to=jsipek@cs.sunysb.edu \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).