From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Hansen Subject: Re: [PATCH 09/26] make access() use mnt check Date: Mon, 02 Jul 2007 09:09:02 -0700 Message-ID: <1183392542.9054.16.camel@localhost> References: <20070622200303.82D9CC3A@kernel> <20070622200314.1310BD44@kernel> <20070623074519.GI27954@infradead.org> <1182796045.1387.7.camel@localhost> <20070630093724.GG22354@infradead.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: akpm@osdl.org, linux-fsdevel@vger.kernel.org, viro@ftp.linux.org.uk To: Christoph Hellwig Return-path: Received: from e32.co.us.ibm.com ([32.97.110.150]:57364 "EHLO e32.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752049AbXGBQRM (ORCPT ); Mon, 2 Jul 2007 12:17:12 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e32.co.us.ibm.com (8.12.11.20060308/8.13.8) with ESMTP id l62GC1oU013356 for ; Mon, 2 Jul 2007 12:12:01 -0400 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l62GHBhT249184 for ; Mon, 2 Jul 2007 10:17:11 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l62GHAD5022472 for ; Mon, 2 Jul 2007 10:17:11 -0600 In-Reply-To: <20070630093724.GG22354@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Sat, 2007-06-30 at 10:37 +0100, Christoph Hellwig wrote: > > --- lxc/fs/namei.c~numa_mnt_want_write 2007-06-25 11:05:50.000000000 -0700 > > +++ lxc-dave/fs/namei.c 2007-06-25 11:05:50.000000000 -0700 > > @@ -230,10 +230,12 @@ int permission(struct inode *inode, int > > int retval, submask; > > > > if (mask & MAY_WRITE) { > > - > > /* > > - * Nobody gets write access to a read-only fs. > > + * If this WARN_ON() is hit, it likely means that > > + * there was a missed mnt_want_write() on the path > > + * leading here. > > */ > > + WARN_ON(__mnt_is_readonly(nd->mnt)); > > if (IS_RDONLY(inode) && > > I might be missing something, but wouldn't this trip an > > access("/foo/bar", W_OK); > > On a readonly filesystem? Yes, it will. I will re-work it a bit. -- Dave