From: Badari Pulavarty <pbadari@us.ibm.com>
To: Zach Brown <zach.brown@oracle.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dio: remove bogus refcounting BUG_ON
Date: Thu, 05 Jul 2007 10:16:59 -0700 [thread overview]
Message-ID: <1183655819.19473.0.camel@dyn9047017100.beaverton.ibm.com> (raw)
In-Reply-To: <3439F83E-9FBD-4743-B2A9-63009B7087FD@oracle.com>
On Thu, 2007-07-05 at 10:11 -0700, Zach Brown wrote:
> > the BUG_ON(). But unfortunately, our perf. team is able reproduce the
> > problem.
>
> What are they doing to reproduce it? How much setup does it take?
Huge OLTP run :(
>
> > Debug indicated that, the ret2 == 1 :(
>
> That could be consistent with the theory that we're racing with the
> dio struct being freed and reused before it's tested in the BUG_ON()
> condition. Suparna's suggestion to sample dio->is_async before
> releasing the refcount and using that in the BUG_ON condition is a
> good one.
I will ask them to try that.
Thanks,
Badari
next prev parent reply other threads:[~2007-07-05 17:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-28 3:01 DIO panic on 2.6.21.5 Badari Pulavarty
2007-06-29 22:10 ` Zach Brown
2007-06-30 0:03 ` Badari Pulavarty
2007-07-03 22:28 ` [PATCH] dio: remove bogus refcounting BUG_ON Zach Brown
2007-07-05 2:25 ` Badari Pulavarty
2007-07-05 3:53 ` Suparna Bhattacharya
2007-07-05 17:11 ` Zach Brown
2007-07-05 17:16 ` Badari Pulavarty [this message]
2007-07-05 17:21 ` Zach Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1183655819.19473.0.camel@dyn9047017100.beaverton.ibm.com \
--to=pbadari@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).