From: Mingming Cao <cmm@us.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
nfsv4@linux-nfs.org, linux-kernel@vger.kernel.org
Subject: Re: [EXT4 set 4][PATCH 1/5] i_version:64 bit inode version
Date: Tue, 10 Jul 2007 18:09:40 -0400 [thread overview]
Message-ID: <1184105380.3759.65.camel@localhost.localdomain> (raw)
In-Reply-To: <20070710163038.ceb2ae94.akpm@linux-foundation.org>
On Tue, 2007-07-10 at 16:30 -0700, Andrew Morton wrote:
> On Sun, 01 Jul 2007 03:37:04 -0400
> Mingming Cao <cmm@us.ibm.com> wrote:
>
> > This patch converts the 32-bit i_version in the generic inode to a 64-bit
> > i_version field.
> >
>
> That's obvious from the patch. But what was the reason for making this
> (unrelated to ext4) change?
>
The need is came from NFSv4
On Fri, 2007-05-25 at 18:25 +0200, Jean noel Cordenner wrote:
> Hi,
>
> This is an update of the i_version patch.
> The i_version field is a 64bit counter that is set on every inode
> creation and that is incremented every time the inode data is modified
> (similarly to the "ctime" time-stamp).
> The aim is to fulfill a NFSv4 requirement for rfc3530:
> "5.5. Mandatory Attributes - Definitions
> Name # DataType Access Description
> ___________________________________________________________________
> change 3 uint64 READ A value created by the
> server that the client can use to determine if file
> data, directory contents or attributes of the object
> have been modified. The servermay return the object's
> time_metadata attribute for this attribute's value but
> only if the filesystem object can not be updated more
> frequently than the resolution of time_metadata.
> "
>
> Please update the changelog for this.
>
Is above description clear to you?
> > Index: linux-2.6.21/include/linux/fs.h
> > ===================================================================
> > --- linux-2.6.21.orig/include/linux/fs.h
> > +++ linux-2.6.21/include/linux/fs.h
> > @@ -549,7 +549,7 @@ struct inode {
> > uid_t i_uid;
> > gid_t i_gid;
> > dev_t i_rdev;
> > - unsigned long i_version;
> > + u64 i_version;
> > loff_t i_size;
> > #ifdef __NEED_I_SIZE_ORDERED
> > seqcount_t i_size_seqcount;
>
next prev parent reply other threads:[~2007-07-10 22:09 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-01 7:37 [EXT4 set 4][PATCH 1/5] i_version:64 bit inode version Mingming Cao
2007-07-02 14:58 ` Mingming Cao
2007-07-03 14:24 ` Trond Myklebust
2007-07-03 21:56 ` Andreas Dilger
2007-07-03 22:15 ` J. Bruce Fields
2007-07-03 23:32 ` Andreas Dilger
2007-07-06 13:51 ` J. Bruce Fields
2007-07-06 22:53 ` Andreas Dilger
2007-07-09 21:16 ` Mingming Cao
2007-07-10 23:30 ` Andrew Morton
2007-07-10 22:09 ` Mingming Cao [this message]
2007-07-11 1:22 ` Andrew Morton
2007-07-11 0:19 ` Mingming Cao
2007-07-11 4:22 ` Andrew Morton
2007-07-11 2:27 ` Mingming Cao
2007-07-11 16:57 ` J. Bruce Fields
2007-07-11 3:21 ` Neil Brown
2007-07-11 2:09 ` Mingming Cao
2007-07-11 5:17 ` Andrew Morton
2007-07-11 3:18 ` Mingming Cao
2007-07-11 6:35 ` Andrew Morton
2007-07-11 3:34 ` Trond Myklebust
2007-07-11 11:41 ` Andreas Dilger
2007-07-11 5:05 ` Neil Brown
2007-07-11 5:22 ` Andrew Morton
2007-07-11 14:28 ` Dave Kleikamp
2007-07-11 20:04 ` J. Bruce Fields
2007-07-12 4:56 ` Andreas Dilger
2007-07-11 17:26 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1184105380.3759.65.camel@localhost.localdomain \
--to=cmm@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nfsv4@linux-nfs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).