From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mingming Cao Subject: Re: new ext4 build warnings Date: Wed, 18 Jul 2007 17:59:19 -0700 Message-ID: <1184806759.19760.3.camel@localhost.localdomain> References: <469E8822.7000104@garzik.org> Reply-To: cmm@us.ibm.com Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Theodore Tso , Linux Kernel Mailing List , linux-fsdevel@vger.kernel.org, Andrew Morton To: Jeff Garzik Return-path: Received: from e3.ny.us.ibm.com ([32.97.182.143]:57680 "EHLO e3.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759408AbXGSA7U (ORCPT ); Wed, 18 Jul 2007 20:59:20 -0400 In-Reply-To: <469E8822.7000104@garzik.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, 2007-07-18 at 17:37 -0400, Jeff Garzik wrote: > It seems jbd_debug() might need modification: >=20 > fs/ext4/inode.c: In function =E2=80=98ext4_write_inode=E2=80=99: > fs/ext4/inode.c:2906: warning: comparison is always true due to limit= ed=20 > range of data type >=20 > fs/jbd2/recovery.c: In function =E2=80=98jbd2_journal_recover=E2=80=99= : > fs/jbd2/recovery.c:254: warning: comparison is always true due to=20 > limited range of data type > fs/jbd2/recovery.c:257: warning: comparison is always true due to=20 > limited range of data type >=20 > fs/jbd2/recovery.c: In function =E2=80=98jbd2_journal_skip_recovery=E2= =80=99: > fs/jbd2/recovery.c:301: warning: comparison is always true due to=20 > limited range of data type >=20 > I'm surprised this was not noticed in a test build before pushing ups= tream. >=20 Hmm, I am not sure what happened. I get the compile warning on linus latest git tree, but could not get the same compile warning on Ted's ext4 git tree.=20 In both build CONFIG_JBD2_DEBUG and DEBUG_FS is enabled. Mingming - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html