linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Chris Mason <chris.mason@oracle.com>,
	Nick Piggin <npiggin@suse.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Memory Management List <linux-mm@kvack.org>,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH RFC] extent mapped page cache
Date: Tue, 24 Jul 2007 23:25:43 +0200	[thread overview]
Message-ID: <1185312343.5535.5.camel@lappy> (raw)
In-Reply-To: <1185307985.6586.50.camel@localhost>

On Tue, 2007-07-24 at 16:13 -0400, Trond Myklebust wrote:
> On Tue, 2007-07-24 at 16:00 -0400, Chris Mason wrote:
> > On Tue, 10 Jul 2007 17:03:26 -0400
> > Chris Mason <chris.mason@oracle.com> wrote:
> > 
> > > This patch aims to demonstrate one way to replace buffer heads with a
> > > few extent trees.  Buffer heads provide a few different features:
> > > 
> > > 1) Mapping of logical file offset to blocks on disk
> > > 2) Recording state (dirty, locked etc)
> > > 3) Providing a mechanism to access sub-page sized blocks.
> > > 
> > > This patch covers #1 and #2, I'll start on #3 a little later next
> > > week.
> > > 
> > Well, almost.  I decided to try out an rbtree instead of the radix,
> > which turned out to be much faster.  Even though individual operations
> > are slower, the rbtree was able to do many fewer ops to accomplish the
> > same thing, especially for merging extents together.  It also uses much
> > less ram.
> 
> The problem with an rbtree is that you can't use it together with RCU to
> do lockless lookups. You can probably modify it to allocate nodes
> dynamically (like the radix tree does) and thus make it RCU-compatible,
> but then you risk losing the two main benefits that you list above.

I thought on this, and I came to the conclusion that the tree rotations
used to balance binary trees are incompatible with RCU. The rotation can
hide one branch. Hence I started writing a B+tree that is RCU compatible
much like the Radix tree.

Current code here:
  http://programming.kicks-ass.net/kernel-patches/vma_lookup/btree.patch

Still needs some work, but is usable.


  reply	other threads:[~2007-07-24 21:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-10 21:03 [PATCH RFC] extent mapped page cache Chris Mason
2007-07-12  7:00 ` Daniel Phillips
2007-07-18 14:18   ` Chris Mason
2007-07-24 20:00 ` Chris Mason
2007-07-24 20:03   ` [PATCH RFC] extent mapped page cache main code Chris Mason
2007-07-24 20:04   ` [PATCH RFC] ext2 extentmap support Chris Mason
2007-07-24 20:13   ` [PATCH RFC] extent mapped page cache Trond Myklebust
2007-07-24 21:25     ` Peter Zijlstra [this message]
2007-07-24 23:25       ` Chris Mason
2007-07-25  2:32         ` Nick Piggin
2007-07-25 12:18           ` Chris Mason
2007-07-26  1:37             ` Nick Piggin
2007-07-26  2:10               ` Chris Mason
2007-07-26  2:36                 ` Nick Piggin
2007-07-26  7:53                   ` Anton Altaparmakov
2007-07-26 13:05                   ` Chris Mason
2007-07-27  1:15                     ` Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1185312343.5535.5.camel@lappy \
    --to=a.p.zijlstra@chello.nl \
    --cc=chris.mason@oracle.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=npiggin@suse.de \
    --cc=trond.myklebust@fys.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).