From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Greg Banks <gnb@sgi.com>
Cc: Jeff Layton <jlayton@redhat.com>,
reiserfs-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
ecryptfs-devel@lists.sourceforge.net, nfs@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, unionfs@filesystems.org,
linux-cifs-client@lists.samba.org
Subject: Re: [NFS] [PATCH 2/7] NFS: if ATTR_KILL_S*ID bits are set, then skip mode change
Date: Mon, 17 Sep 2007 09:10:47 -0400 [thread overview]
Message-ID: <1190034647.6700.3.camel@heimdal.trondhjem.org> (raw)
In-Reply-To: <20070914154345.GE25610@sgi.com>
On Sat, 2007-09-15 at 01:43 +1000, Greg Banks wrote:
> On Fri, Sep 14, 2007 at 10:58:38AM -0400, Jeff Layton wrote:
> > If Irix isn't clearing these bits
> > on a write then it might be good to see if they can fix that...
>
> I think first you'd have to mount a serious argument that it's broken,
> more serious than "it works differently from Linux".
How about: "If IRIX isn't clearing these bits then they're leaving their
customers wide open to all sorts of security issues."
Unless you make the chmod/chgrp atomic with the write, then there will
always be a way for a client to inject data while the setuid/setgid bits
are set: basically, it allows said client to rewrite a setuid/setgid
executable.
We're not fixing this in the client because it isn't fixable on the
client.
Trond
prev parent reply other threads:[~2007-09-17 13:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-04 14:37 [PATCH 2/7] NFS: if ATTR_KILL_S*ID bits are set, then skip mode change Jeff Layton
2007-09-14 10:25 ` [NFS] " Greg Banks
2007-09-14 11:02 ` Jeff Layton
2007-09-14 13:09 ` Greg Banks
2007-09-14 13:38 ` Jeff Layton
2007-09-14 14:40 ` [NFS] " Greg Banks
2007-09-14 14:58 ` Jeff Layton
2007-09-14 15:43 ` Greg Banks
2007-09-14 16:01 ` Jeff Layton
2007-09-17 13:10 ` Trond Myklebust [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1190034647.6700.3.camel@heimdal.trondhjem.org \
--to=trond.myklebust@fys.uio.no \
--cc=ecryptfs-devel@lists.sourceforge.net \
--cc=gnb@sgi.com \
--cc=jlayton@redhat.com \
--cc=linux-cifs-client@lists.samba.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nfs@lists.sourceforge.net \
--cc=reiserfs-devel@vger.kernel.org \
--cc=unionfs@filesystems.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).