From: Erez Zadok <ezk@cs.sunysb.edu>
To: akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
viro@ftp.linux.org.uk, hch@infradead.org,
Erez Zadok <ezk@cs.sunysb.edu>
Subject: [PATCH 13/19] Unionfs: remove periods from the end of printk strings
Date: Mon, 1 Oct 2007 01:50:50 -0400 [thread overview]
Message-ID: <1191217861181-git-send-email-ezk@cs.sunysb.edu> (raw)
In-Reply-To: <1191217856647-git-send-email-ezk@cs.sunysb.edu>
Signed-off-by: Erez Zadok <ezk@cs.sunysb.edu>
---
fs/unionfs/lookup.c | 2 +-
fs/unionfs/main.c | 2 +-
fs/unionfs/rename.c | 4 ++--
fs/unionfs/super.c | 10 +++++-----
4 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/fs/unionfs/lookup.c b/fs/unionfs/lookup.c
index 981c0d9..929f15b 100644
--- a/fs/unionfs/lookup.c
+++ b/fs/unionfs/lookup.c
@@ -215,7 +215,7 @@ struct dentry *unionfs_lookup_backend(struct dentry *dentry,
}
err = -EIO;
printk(KERN_ERR "unionfs: EIO: invalid whiteout "
- "entry type %d.\n",
+ "entry type %d\n",
wh_lower_dentry->d_inode->i_mode);
dput(wh_lower_dentry);
dput(first_lower_dentry);
diff --git a/fs/unionfs/main.c b/fs/unionfs/main.c
index 25d1461..25ac851 100644
--- a/fs/unionfs/main.c
+++ b/fs/unionfs/main.c
@@ -485,7 +485,7 @@ static struct unionfs_dentry_info *unionfs_parse_options(
* don't, above this check.
*/
if (!optarg) {
- printk(KERN_ERR "unionfs: %s requires an argument.\n",
+ printk(KERN_ERR "unionfs: %s requires an argument\n",
optname);
err = -EINVAL;
goto out_error;
diff --git a/fs/unionfs/rename.c b/fs/unionfs/rename.c
index c90405d..81121f0 100644
--- a/fs/unionfs/rename.c
+++ b/fs/unionfs/rename.c
@@ -294,14 +294,14 @@ revert:
local_err = unionfs_refresh_lower_dentry(new_dentry, old_bstart);
if (local_err) {
printk(KERN_ERR "unionfs: revert failed in rename: "
- "the new refresh failed.\n");
+ "the new refresh failed\n");
eio = -EIO;
}
local_err = unionfs_refresh_lower_dentry(old_dentry, old_bstart);
if (local_err) {
printk(KERN_ERR "unionfs: revert failed in rename: "
- "the old refresh failed.\n");
+ "the old refresh failed\n");
eio = -EIO;
goto revert_out;
}
diff --git a/fs/unionfs/super.c b/fs/unionfs/super.c
index 798def9..647b08c 100644
--- a/fs/unionfs/super.c
+++ b/fs/unionfs/super.c
@@ -173,18 +173,18 @@ static noinline int do_remount_mode_option(char *optarg, int cur_branches,
/* by now, optarg contains the branch name */
if (!*optarg) {
printk(KERN_ERR
- "unionfs: no branch specified for mode change.\n");
+ "unionfs: no branch specified for mode change\n");
goto out;
}
if (!modename) {
- printk(KERN_ERR "unionfs: branch \"%s\" requires a mode.\n",
+ printk(KERN_ERR "unionfs: branch \"%s\" requires a mode\n",
optarg);
goto out;
}
*modename++ = '\0';
perms = __parse_branch_mode(modename);
if (perms == 0) {
- printk(KERN_ERR "unionfs: invalid mode \"%s\" for \"%s\".\n",
+ printk(KERN_ERR "unionfs: invalid mode \"%s\" for \"%s\"\n",
modename, optarg);
goto out;
}
@@ -584,7 +584,7 @@ static int unionfs_remount_fs(struct super_block *sb, int *flags,
*/
if (!optarg || !*optarg) {
printk(KERN_ERR "unionfs: all remount options require "
- "an argument (%s).\n", optname);
+ "an argument (%s)\n", optname);
err = -EINVAL;
goto out_release;
}
@@ -634,7 +634,7 @@ static int unionfs_remount_fs(struct super_block *sb, int *flags,
*/
if (!strcmp("dirs", optname)) {
printk(KERN_WARNING
- "unionfs: remount ignoring option \"%s\".\n",
+ "unionfs: remount ignoring option \"%s\"\n",
optname);
continue;
}
--
1.5.2.2
next prev parent reply other threads:[~2007-10-01 5:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-01 5:50 [GIT PULL -mm] 00/19 Unionfs updates/cleanups/fixes Erez Zadok
2007-10-01 5:50 ` [PATCH 01/19] Unionfs: compile if debug is off Erez Zadok
2007-10-01 5:50 ` [PATCH 02/19] Unionfs: add un/likely on conditionals Erez Zadok
2007-10-01 5:50 ` [PATCH 03/19] Unionfs: minor comment cleanups Erez Zadok
2007-10-01 5:50 ` [PATCH 04/19] Unionfs: use consistent printk prefixes Erez Zadok
2007-10-01 5:50 ` [PATCH 05/19] Unionfs: use UNIONFS_NAME macro Erez Zadok
2007-10-01 5:50 ` [PATCH 06/19] Unionfs: properly indent static struct Erez Zadok
2007-10-01 5:50 ` [PATCH 07/19] Unionfs: remove unnecessary if condition Erez Zadok
2007-10-01 5:50 ` [PATCH 08/19] Unionfs: use page_offset() helper Erez Zadok
2007-10-01 5:50 ` [PATCH 09/19] Unionfs: use pr_debug() instead of custom dprintk() Erez Zadok
2007-10-01 5:50 ` [PATCH 10/19] Unionfs: convert all appropriate printk's to pr_debug calls Erez Zadok
2007-10-01 5:50 ` [PATCH 11/19] Unionfs: add missing newlines in printk's Erez Zadok
2007-10-01 5:50 ` [PATCH 12/19] Unionfs: update/assign a KERN_* level to all printk statements Erez Zadok
2007-10-01 5:50 ` Erez Zadok [this message]
2007-10-01 5:50 ` [PATCH 14/19] Unionfs: use braces in both branches of conditionals Erez Zadok
2007-10-01 5:50 ` [PATCH 15/19] Unionfs: coding style: proper spacing Erez Zadok
2007-10-01 5:50 ` [PATCH 16/19] Unionfs: coding style: take assignments out of "if" conditions Erez Zadok
2007-10-01 5:50 ` [PATCH 17/19] Unionfs: coding style: avoid multiple assignments on same line Erez Zadok
2007-10-01 5:50 ` [PATCH 18/19] Unionfs: coding style: miscellaneous fixes Erez Zadok
2007-10-01 5:50 ` [PATCH 19/19] Unionfs: coding style: avoid lines longer than 80 chars Erez Zadok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1191217861181-git-send-email-ezk@cs.sunysb.edu \
--to=ezk@cs.sunysb.edu \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).