From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: SLUB performance regression vs SLAB Date: Thu, 04 Oct 2007 20:26:12 +0200 Message-ID: <1191522372.5574.39.camel@lappy> References: <20070919033605.785839297@sgi.com> <200709280742.38262.nickpiggin@yahoo.com.au> <200709281514.48293.nickpiggin@yahoo.com.au> <20071004161621.GO12049@parisc-linux.org> <20071004105046.7b019fe8@laptopd505.fenrus.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Christoph Lameter , Matthew Wilcox , Nick Piggin , Christoph Hellwig , Mel Gorman , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, David Chinner , Jens Axboe To: Arjan van de Ven Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:43634 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756064AbXJDScE (ORCPT ); Thu, 4 Oct 2007 14:32:04 -0400 In-Reply-To: <20071004105046.7b019fe8@laptopd505.fenrus.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, 2007-10-04 at 10:50 -0700, Arjan van de Ven wrote: > On Thu, 4 Oct 2007 10:38:15 -0700 (PDT) > Christoph Lameter wrote: > > > > Yeah the fastpath vs. slow path is not the issue as Siddha and I > > concluded earlier. Seems that we are mainly seeing cacheline bouncing > > due to two cpus accessing meta data in the same page struct. The > > patches in MM that are scheduled to be merged for .24 address > > > Ok every time something says anything not 100% positive about SLUB you > come back with "but it's fixed in the next patch set"... *every time*. > > To be honest, to me that sounds that SLUB isn't ready for prime time > yet, or at least not ready to be the only one in town... > > The day that the answer is "the kernel.org slub is fixing all the > issues" is when it's ready.. Arjan, to be honest, there has been some confusion on _what_ code has been tested with what results. And with Christoph not able to reproduce these results locally, it is very hard for him to fix it proper.