linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Erez Zadok <ezk@cs.sunysb.edu>
To: hch@infradead.org, viro@ftp.linux.org.uk, akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: [PATCH] 0/3 fs/ioctl.c coding style, rename vfs_ioctl/do_ioctl
Date: Sat, 27 Oct 2007 19:10:42 -0400	[thread overview]
Message-ID: <11935266454097-git-send-email-ezk@cs.sunysb.edu> (raw)


This series of three proposed patches changes fs/ioctl.c and Unionfs as
follows.  This series is against v2.6.24-rc1-192-gef49c32.

Patch 1: just applies coding standards to fs/ioctl.c (while I'm at it, I
figured it's worth cleaning VFS files one at a time).

Patch 2: does two things:

(a) Renames the old vfs_ioctl to do_ioctl, because the comment above the old
    vfs_ioctl clearly indicates that it is an internal function not to be
    exported to modules; therefore it should have a more traditional do_XXX
    "internal function" name.  The new do_ioctl is exported in fs.h but not
    to modules.

(b) Renames the old (static) do_ioctl to vfs_ioctl because the names vfs_XXX
    should preferably be reserved to callable VFS functions which modules
    may call, as other vfs_XXX functions already do.  Export the new
    vfs_ioctl to modules so others can use it (including Unionfs and
    eCryptfs).

Patch 3: demonstrates how Unionfs can use the new vfs_ioctl.  I successfully
tested unionfs with this new exported vfs_ioctl.  (eCryptfs could do the
same.)

I'd like to propose that the first two patches be merged in -mm and even
mainline, pending review.

Erez Zadok (3):
      VFS: apply coding standards to fs/ioctl.c
      VFS: swap do_ioctl and vfs_ioctl names
      Unionfs: use vfs_ioctl

 fs/compat_ioctl.c       |    2 
 fs/ioctl.c              |  176 ++++++++++++++++++++++++------------------------
 fs/unionfs/commonfops.c |   22 +-----
 include/linux/fs.h      |    3 

Cheers,
Erez.

             reply	other threads:[~2007-10-27 23:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-27 23:10 Erez Zadok [this message]
2007-10-27 23:10 ` [PATCH 1/3] VFS: apply coding standards to fs/ioctl.c Erez Zadok
2007-10-28 14:12   ` Christoph Hellwig
2007-10-28 18:05     ` Erez Zadok
2007-10-30  9:54       ` Christoph Hellwig
2007-10-29  2:57     ` Daniel Phillips
2007-10-30  9:55       ` Christoph Hellwig
2007-10-27 23:10 ` [PATCH 2/3] VFS: swap do_ioctl and vfs_ioctl names Erez Zadok
2007-10-28 14:14   ` Christoph Hellwig
2007-10-27 23:10 ` [PATCH 3/3] Unionfs: use vfs_ioctl Erez Zadok

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11935266454097-git-send-email-ezk@cs.sunysb.edu \
    --to=ezk@cs.sunysb.edu \
    --cc=akpm@linux-foundation.org \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).