linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Erez Zadok <ezk@cs.sunysb.edu>
To: akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	viro@ftp.linux.org.uk, hch@infradead.org,
	Hugh Dickins <hugh@veritas.com>, Erez Zadok <ezk@cs.sunysb.edu>
Subject: [PATCH 02/16] Unionfs: minor cleanup in writepage
Date: Mon, 26 Nov 2007 11:43:59 -0500	[thread overview]
Message-ID: <1196095453208-git-send-email-ezk@cs.sunysb.edu> (raw)
In-Reply-To: <11960954531503-git-send-email-ezk@cs.sunysb.edu>

From: Hugh Dickins <hugh@veritas.com>

Signed-off-by: Erez Zadok <ezk@cs.sunysb.edu>
---
 fs/unionfs/mmap.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/unionfs/mmap.c b/fs/unionfs/mmap.c
index 4918f77..1e10280 100644
--- a/fs/unionfs/mmap.c
+++ b/fs/unionfs/mmap.c
@@ -56,6 +56,7 @@ static int unionfs_writepage(struct page *page, struct writeback_control *wbc)
 	copy_highpage(lower_page, page);
 	flush_dcache_page(lower_page);
 	SetPageUptodate(lower_page);
+	set_page_dirty(lower_page);
 
 	/*
 	 * Call lower writepage (expects locked page).  However, if we are
@@ -66,12 +67,11 @@ static int unionfs_writepage(struct page *page, struct writeback_control *wbc)
 	 * success.
 	 */
 	if (wbc->for_reclaim) {
-		set_page_dirty(lower_page);
 		unlock_page(lower_page);
 		goto out_release;
 	}
+
 	BUG_ON(!lower_mapping->a_ops->writepage);
-	set_page_dirty(lower_page);
 	clear_page_dirty_for_io(lower_page); /* emulate VFS behavior */
 	err = lower_mapping->a_ops->writepage(lower_page, wbc);
 	if (err < 0)
-- 
1.5.2.2


  parent reply	other threads:[~2007-11-26 16:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-26 16:43 [GIT PULL -mm] 00/16 Unionfs updates/fixes/cleanups Erez Zadok
2007-11-26 16:43 ` [PATCH 01/16] Unionfs: use f_path instead of f_dentry/mnt Erez Zadok
2007-11-26 16:43 ` Erez Zadok [this message]
2007-11-26 16:44 ` [PATCH 03/16] Unionfs: minor coding standards applied Erez Zadok
2007-11-26 16:44 ` [PATCH 04/16] Unionfs: minor cleanup in the debugging infrastructure Erez Zadok
2007-11-26 16:44 ` [PATCH 05/16] Unionfs: set lower mnt after mkdir which resulted in copyup Erez Zadok
2007-11-26 16:44 ` [PATCH 06/16] Unionfs: handle whiteouts more efficiently in filldir Erez Zadok
2007-11-26 16:44 ` [PATCH 07/16] Unionfs: remove useless debugging messages Erez Zadok
2007-11-26 16:44 ` [PATCH 08/16] Unionfs: release lower resources on successful rmdir Erez Zadok
2007-11-26 16:44 ` [PATCH 09/16] Unionfs: don't create whiteouts on rightmost branch Erez Zadok
2007-11-26 16:44 ` [PATCH 10/16] Unionfs: create opaque directories' whiteouts unconditionally Erez Zadok
2007-11-26 16:44 ` [PATCH 11/16] Unionfs: update times in setattr Erez Zadok
2007-11-26 16:44 ` [PATCH 12/16] Unionfs: reintroduce a bmap method Erez Zadok
2007-11-26 16:44 ` [PATCH 13/16] Unionfs: support splice(2) Erez Zadok
2007-11-26 16:44 ` [PATCH 14/16] Unionfs: prevent multiple writers to lower_page Erez Zadok
2007-11-26 16:44 ` [PATCH 15/16] Unionfs: update our inode size correctly upon partial write Erez Zadok
2007-11-26 16:44 ` [PATCH 16/16] Unionfs: use generic_file_aio_read/write Erez Zadok

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1196095453208-git-send-email-ezk@cs.sunysb.edu \
    --to=ezk@cs.sunysb.edu \
    --cc=akpm@linux-foundation.org \
    --cc=hch@infradead.org \
    --cc=hugh@veritas.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).