linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Erez Zadok <ezk@cs.sunysb.edu>
To: akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	viro@ftp.linux.org.uk, hch@infradead.org,
	Erez Zadok <ezk@cs.sunysb.edu>
Subject: [PATCH 13/16] Unionfs: support splice(2)
Date: Mon, 26 Nov 2007 11:44:10 -0500	[thread overview]
Message-ID: <1196095458112-git-send-email-ezk@cs.sunysb.edu> (raw)
In-Reply-To: <11960954531503-git-send-email-ezk@cs.sunysb.edu>

Also remove redundant variable from unionfs_readpage (saves a bit on stack
space).

Signed-off-by: Erez Zadok <ezk@cs.sunysb.edu>
---
 fs/unionfs/file.c |    1 +
 fs/unionfs/mmap.c |   10 ++++++++--
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/fs/unionfs/file.c b/fs/unionfs/file.c
index cfbfb8e..b7d0d55 100644
--- a/fs/unionfs/file.c
+++ b/fs/unionfs/file.c
@@ -246,4 +246,5 @@ struct file_operations unionfs_main_fops = {
 	.fsync		= unionfs_fsync,
 	.fasync		= unionfs_fasync,
 	.splice_read	= generic_file_splice_read,
+	.splice_write	= generic_file_splice_write,
 };
diff --git a/fs/unionfs/mmap.c b/fs/unionfs/mmap.c
index fa358ef..623a913 100644
--- a/fs/unionfs/mmap.c
+++ b/fs/unionfs/mmap.c
@@ -147,7 +147,7 @@ static int unionfs_readpage(struct file *file, struct page *page)
 	struct inode *inode;
 	mm_segment_t old_fs;
 	char *page_data = NULL;
-	loff_t offset;
+	mode_t orig_mode;
 
 	unionfs_read_lock(file->f_path.dentry->d_sb);
 	err = unionfs_file_revalidate(file, false);
@@ -175,11 +175,17 @@ static int unionfs_readpage(struct file *file, struct page *page)
 	 * the necessary magic for us.
 	 */
 	lower_file->f_pos = page_offset(page);
-	offset = page_offset(page);
 	old_fs = get_fs();
 	set_fs(KERNEL_DS);
+	/*
+	 * generic_file_splice_write may call us on a file not opened for
+	 * reading, so temporarily allow reading.
+	 */
+	orig_mode = lower_file->f_mode;
+	lower_file->f_mode |= FMODE_READ;
 	err = vfs_read(lower_file, page_data, PAGE_CACHE_SIZE,
 		       &lower_file->f_pos);
+	lower_file->f_mode = orig_mode;
 	set_fs(old_fs);
 	if (err >= 0 && err < PAGE_CACHE_SIZE)
 		memset(page_data + err, 0, PAGE_CACHE_SIZE - err);
-- 
1.5.2.2


  parent reply	other threads:[~2007-11-26 16:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-26 16:43 [GIT PULL -mm] 00/16 Unionfs updates/fixes/cleanups Erez Zadok
2007-11-26 16:43 ` [PATCH 01/16] Unionfs: use f_path instead of f_dentry/mnt Erez Zadok
2007-11-26 16:43 ` [PATCH 02/16] Unionfs: minor cleanup in writepage Erez Zadok
2007-11-26 16:44 ` [PATCH 03/16] Unionfs: minor coding standards applied Erez Zadok
2007-11-26 16:44 ` [PATCH 04/16] Unionfs: minor cleanup in the debugging infrastructure Erez Zadok
2007-11-26 16:44 ` [PATCH 05/16] Unionfs: set lower mnt after mkdir which resulted in copyup Erez Zadok
2007-11-26 16:44 ` [PATCH 06/16] Unionfs: handle whiteouts more efficiently in filldir Erez Zadok
2007-11-26 16:44 ` [PATCH 07/16] Unionfs: remove useless debugging messages Erez Zadok
2007-11-26 16:44 ` [PATCH 08/16] Unionfs: release lower resources on successful rmdir Erez Zadok
2007-11-26 16:44 ` [PATCH 09/16] Unionfs: don't create whiteouts on rightmost branch Erez Zadok
2007-11-26 16:44 ` [PATCH 10/16] Unionfs: create opaque directories' whiteouts unconditionally Erez Zadok
2007-11-26 16:44 ` [PATCH 11/16] Unionfs: update times in setattr Erez Zadok
2007-11-26 16:44 ` [PATCH 12/16] Unionfs: reintroduce a bmap method Erez Zadok
2007-11-26 16:44 ` Erez Zadok [this message]
2007-11-26 16:44 ` [PATCH 14/16] Unionfs: prevent multiple writers to lower_page Erez Zadok
2007-11-26 16:44 ` [PATCH 15/16] Unionfs: update our inode size correctly upon partial write Erez Zadok
2007-11-26 16:44 ` [PATCH 16/16] Unionfs: use generic_file_aio_read/write Erez Zadok

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1196095458112-git-send-email-ezk@cs.sunysb.edu \
    --to=ezk@cs.sunysb.edu \
    --cc=akpm@linux-foundation.org \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).