Re: [PATCHSET 2/2] libfuse: new mount service container fixes

[Bernd Schubert <bernd@bsbernd.com>]

Hi Darrick

On 5/8/26 00:13, Darrick J. Wong wrote:
> Hi all,
> 
> This is a collection of bug fixes and cppcheck cleanups for the new fuse
> service container code.
> 
> With a bit of luck, this should all go splendidly.
> Comments and questions are, as always, welcome.
> 
> --D
> ---
> Commits in this patchset:
>  * mount_service: use the mount_flags table instead of declaring our own
> ---
>  util/mount_service.c |   51 +++++++++++++-------------------------------------
>  1 file changed, 13 insertions(+), 38 deletions(-)
> 
> 

coud you please add this or or something similar to your series, to
silence gcc static checker warnings?

commit 670fb8f4a248cfd50af43510033b8b3167d75df6 (HEAD ->
fuse-service-container)
Author: Bernd Schubert <bernd@bsbernd.com>
Date:   Fri May 8 19:00:02 2026 +0200

    Fix deref-before-check in mount.fuse.c

diff --git a/util/mount.fuse.c b/util/mount.fuse.c
index 802d7f99fe78..00b133e62344 100644
--- a/util/mount.fuse.c
+++ b/util/mount.fuse.c
@@ -384,7 +384,7 @@ int main(int argc, char *argv[])
        }

        source = argv[1];
-       if (!source[0])
+       if (source && !source[0])
                source = NULL;

        mountpoint = argv[2];



All your "Fixes:" commit messages run into

bschubert2@imesrv6 libfuse.git>.github/workflows/run-checkpatch.sh &&
stg push
No typos will be found - file
'/home/bschubert2/src/libfuse/libfuse.git/spelling.txt': No such file or
directory
No structs that should be const will be found - file
'/home/bschubert2/src/libfuse/libfuse.git/const_structs.checkpatch': No
such file or directory
WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12 chars
of sha1> ("<title line>")' - ie: 'Fixes: 3e1101057aea ("fuse mount:
Support synchronous FUSE_INIT (privileged daemon)")'
#10:
Fixes: 3e1101057aea57 ("fuse mount: Support synchronous FUSE_INIT
(privileged daemon)")

total: 0 errors, 1 warnings, 12 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or
--fix-inplace.

Commit a9e52715f595 ("libfuse: don't use SYNC_INIT unless asked for")
has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS COMMIT_MESSAGE COMPLEX_MACRO
EMAIL_SUBJECT ENOSYS ENOSYS_SYSCALL FILE_PATH_CHANGES
FROM_SIGN_OFF_MISMATCH GIT_COMMIT_ID MAINTAINERS
PREFER_ATTRIBUTE_ALWAYS_UNUSED PREFER_DEFINED_ATTRIBUTE_MACRO
QUOTED_COMMIT_ID SPDX_LICENSE_TAG STRCPY STRNCPY

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


Is does linux checkpatch use two chars more for the hash in the mean
time than what libfuse/checkpatch.pl has?


Thanks,
Bernd