From: Joel Becker <joel.becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 08/10] ocfs2: Change mlog_bug_on to BUG_ON in ocfs2_lockid.h
Date: Wed, 5 Mar 2008 17:13:56 -0800 [thread overview]
Message-ID: <1204766038-31721-9-git-send-email-joel.becker@oracle.com> (raw)
In-Reply-To: <1204766038-31721-1-git-send-email-joel.becker@oracle.com>
The masklog code is in the o2cb stack, but ocfs2_lockid.h now needs to
be included by the user stack. The BUG() in ocfs2_lock_type_string()
does not need masklog support, so change it to a regular BUG_ON().
Signed-off-by: Joel Becker <joel.becker@oracle.com>
---
fs/ocfs2/ocfs2_lockid.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/ocfs2/ocfs2_lockid.h b/fs/ocfs2/ocfs2_lockid.h
index 86f3e37..82c200f 100644
--- a/fs/ocfs2/ocfs2_lockid.h
+++ b/fs/ocfs2/ocfs2_lockid.h
@@ -100,7 +100,7 @@ static char *ocfs2_lock_type_strings[] = {
static inline const char *ocfs2_lock_type_string(enum ocfs2_lock_type type)
{
#ifdef __KERNEL__
- mlog_bug_on_msg(type >= OCFS2_NUM_LOCK_TYPES, "%d\n", type);
+ BUG_ON(type >= OCFS2_NUM_LOCK_TYPES);
#endif
return ocfs2_lock_type_strings[type];
}
--
1.5.3.8
next prev parent reply other threads:[~2008-03-06 1:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-06 1:13 [PATCH 0/10] ocfs2: Userspace cluster stack support Joel Becker
2008-03-06 1:13 ` [PATCH 01/10] ocfs2: Add the user stack module Joel Becker
2008-03-06 1:13 ` [PATCH 02/10] ocfs2: Add the ocfs2_control misc device Joel Becker
2008-03-06 1:13 ` [PATCH 03/10] ocfs2: Start the ocfs2_control handshake Joel Becker
2008-03-06 1:13 ` [PATCH 04/10] ocfs2: Introduce the DOWN message to ocfs2_control Joel Becker
2008-03-06 1:13 ` [PATCH 05/10] ocfs2: Add the local node id to the handshake Joel Becker
2008-03-06 1:13 ` [PATCH 06/10] ocfs2: Add the 'set version' message to the ocfs2_control device Joel Becker
2008-03-06 1:13 ` [PATCH 07/10] ocfs2: add fsdlm to stackglue Joel Becker
2008-03-06 1:13 ` Joel Becker [this message]
2008-03-06 1:13 ` [PATCH 09/10] ocfs2: Add kbuild for ocfs2_stack_user.ko Joel Becker
2008-03-06 1:13 ` [PATCH 10/10] ocfs2: Allow selection of cluster plug-ins Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1204766038-31721-9-git-send-email-joel.becker@oracle.com \
--to=joel.becker@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).