Re: [RFC][PATCH 0/3] ext4 online defrag (ver 0.7)

[Mingming Cao <cmm@us.ibm.com>]

On Thu, 2008-03-06 at 09:01 +0900, Akira Fujita wrote:
> Hi all,
> 
> I have updated ext4 online defrag to interchange
> the data blocks of the target and temporary files 
> in an atomic manner.
> We have no corruption in the target file anymore
> if unexpected system down occurs while doing defrag.  
> 

Thanks for the update.

> Next step:
> Remove the limit of target file size (now 128MB) in -f mode.
> * Past mail concerning -f mode.
> http://marc.info/?l=linux-ext4&m=118239067704899&w=4
> 

The old version have many useful high level description, could you
preserve that and add to the change logs in this updated series?

> Dependency:
> My patches depend on the multi-block allocation in ext4 patch queue.
> 
mballoc patch already in maintain so this dependency could be removed.

> Summary of patches:
> * These patches are applied on the top of
>   ext4 git tree(linux-2.6.25-rc3-git4). 
>   http://repo.or.cz/r/ext4-patch-queue.git
>   And attached files are the updated patches.
> 

I assume the following three patches are diffs against current ext4
patch queue

> [PATCH 1/3]
>  - Interchange the data blocks of the target and
>    temporary files in an atomic manner.
> 
> [PATCH 2/3]
> 　- Change the name of functions.
> 　   ext4_ext_xxx -> ext4_defrag_xxx
> 　- Some cleanups.
> 
> [PATCH 3/3] ext4 online defrag command
>  - Change the error handling for ext4_iget().
>  - Usage is as follows:
>    o Put the multiple files closer together.
>      # e4defrag -r directory-name
>    o Defrag for free space fragmentation.
>      # e4defrag -f file-name
>    o Defrag for a single file.
>      # e4defrag file-name
>    o Defrag for all files on ext4.
>      # e4defrag device-name
> 
> Review and comment are welcome.
> 

Attempted to do so...

The updated patch series could not compile one-by-one, could you rework
the series so that in the future we could able to bi-search the ext4
patch queue? As a whole, I got compile warning when applied all the
updated patches:(

review comments against the 4 updated kernel patches to follow.

Mingming

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html