From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: linux-fsdevel@vger.kernel.org
Cc: Duane Griffin <duaneg@dghda.com>
Subject: [PATCH] fix up thinko in jbd2 revoke code
Date: Mon, 31 Mar 2008 10:57:42 -0500 [thread overview]
Message-ID: <1206979062.3192.26.camel@localhost.localdomain> (raw)
This commit:
commit e898f3154d78d1520265aade0992981866d827fb
Author: Duane Griffin <duaneg@dghda.com>
Date: Tue Mar 25 19:47:39 2008 -0400
jbd2: tidy up revoke cache initialisation and destruction
Introduced a thinko (it doesn't check whether jbd2_revoke_record cache
is null, it checks jbd2_revoke_table_cache twice).
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
---
diff --git a/fs/jbd2/revoke.c b/fs/jbd2/revoke.c
index e13584a..4dc5b85 100644
--- a/fs/jbd2/revoke.c
+++ b/fs/jbd2/revoke.c
@@ -192,7 +192,7 @@ int __init jbd2_journal_init_revoke_caches(void)
jbd2_revoke_table_cache = kmem_cache_create("jbd2_revoke_table",
sizeof(struct jbd2_revoke_table_s),
0, SLAB_TEMPORARY, NULL);
- if (jbd2_revoke_table_cache && jbd2_revoke_table_cache) {
+ if (jbd2_revoke_record_cache && jbd2_revoke_table_cache) {
return 0;
} else {
jbd2_journal_destroy_revoke_caches();
next reply other threads:[~2008-03-31 15:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-31 15:57 James Bottomley [this message]
2008-03-31 18:30 ` [PATCH] fix up thinko in jbd2 revoke code Mingming Cao
2008-04-03 16:17 ` Christoph Hellwig
2008-04-21 9:54 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1206979062.3192.26.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=duaneg@dghda.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).