From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: [PATCH] fix up thinko in jbd2 revoke code Date: Mon, 31 Mar 2008 10:57:42 -0500 Message-ID: <1206979062.3192.26.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Duane Griffin To: linux-fsdevel@vger.kernel.org Return-path: Received: from accolon.hansenpartnership.com ([76.243.235.52]:43365 "EHLO accolon.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751497AbYCaP5q (ORCPT ); Mon, 31 Mar 2008 11:57:46 -0400 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: This commit: commit e898f3154d78d1520265aade0992981866d827fb Author: Duane Griffin Date: Tue Mar 25 19:47:39 2008 -0400 jbd2: tidy up revoke cache initialisation and destruction Introduced a thinko (it doesn't check whether jbd2_revoke_record cache is null, it checks jbd2_revoke_table_cache twice). Signed-off-by: James Bottomley --- diff --git a/fs/jbd2/revoke.c b/fs/jbd2/revoke.c index e13584a..4dc5b85 100644 --- a/fs/jbd2/revoke.c +++ b/fs/jbd2/revoke.c @@ -192,7 +192,7 @@ int __init jbd2_journal_init_revoke_caches(void) jbd2_revoke_table_cache = kmem_cache_create("jbd2_revoke_table", sizeof(struct jbd2_revoke_table_s), 0, SLAB_TEMPORARY, NULL); - if (jbd2_revoke_table_cache && jbd2_revoke_table_cache) { + if (jbd2_revoke_record_cache && jbd2_revoke_table_cache) { return 0; } else { jbd2_journal_destroy_revoke_caches();