Re: [PATCH] fix up thinko in jbd2 revoke code

[Mingming Cao <cmm@us.ibm.com>]

On Mon, 2008-03-31 at 10:57 -0500, James Bottomley wrote:
> This commit:
> 
> commit e898f3154d78d1520265aade0992981866d827fb
> Author: Duane Griffin <duaneg@dghda.com>
> Date:   Tue Mar 25 19:47:39 2008 -0400
> 
>     jbd2: tidy up revoke cache initialisation and destruction
> 
> Introduced a thinko (it doesn't check whether jbd2_revoke_record cache
> is null, it checks jbd2_revoke_table_cache twice).
> 
> Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
> 
Signed-off-by: Mingming Cao <cmm@us.ibm.com>

Thanks, I picked this up in ext4 patch queue.

Mingming
> ---
> 
> diff --git a/fs/jbd2/revoke.c b/fs/jbd2/revoke.c
> index e13584a..4dc5b85 100644
> --- a/fs/jbd2/revoke.c
> +++ b/fs/jbd2/revoke.c
> @@ -192,7 +192,7 @@ int __init jbd2_journal_init_revoke_caches(void)
>  	jbd2_revoke_table_cache = kmem_cache_create("jbd2_revoke_table",
>  					   sizeof(struct jbd2_revoke_table_s),
>  					   0, SLAB_TEMPORARY, NULL);
> -	if (jbd2_revoke_table_cache && jbd2_revoke_table_cache) {
> +	if (jbd2_revoke_record_cache && jbd2_revoke_table_cache) {
>  		return 0;
>  	} else {
>  		jbd2_journal_destroy_revoke_caches();
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html