From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mingming Cao Subject: Re: [PATCH] fix up thinko in jbd2 revoke code Date: Mon, 31 Mar 2008 11:30:58 -0700 Message-ID: <1206988258.3653.2.camel@localhost.localdomain> References: <1206979062.3192.26.camel@localhost.localdomain> Reply-To: cmm@us.ibm.com Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, Duane Griffin To: James Bottomley Return-path: Received: from e6.ny.us.ibm.com ([32.97.182.146]:53620 "EHLO e6.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753184AbYCaSbA (ORCPT ); Mon, 31 Mar 2008 14:31:00 -0400 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e6.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id m2VIX2ur016800 for ; Mon, 31 Mar 2008 14:33:02 -0400 Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m2VIUxho200378 for ; Mon, 31 Mar 2008 14:30:59 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m2VIUwCZ015157 for ; Mon, 31 Mar 2008 14:30:59 -0400 In-Reply-To: <1206979062.3192.26.camel@localhost.localdomain> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, 2008-03-31 at 10:57 -0500, James Bottomley wrote: > This commit: > > commit e898f3154d78d1520265aade0992981866d827fb > Author: Duane Griffin > Date: Tue Mar 25 19:47:39 2008 -0400 > > jbd2: tidy up revoke cache initialisation and destruction > > Introduced a thinko (it doesn't check whether jbd2_revoke_record cache > is null, it checks jbd2_revoke_table_cache twice). > > Signed-off-by: James Bottomley > Signed-off-by: Mingming Cao Thanks, I picked this up in ext4 patch queue. Mingming > --- > > diff --git a/fs/jbd2/revoke.c b/fs/jbd2/revoke.c > index e13584a..4dc5b85 100644 > --- a/fs/jbd2/revoke.c > +++ b/fs/jbd2/revoke.c > @@ -192,7 +192,7 @@ int __init jbd2_journal_init_revoke_caches(void) > jbd2_revoke_table_cache = kmem_cache_create("jbd2_revoke_table", > sizeof(struct jbd2_revoke_table_s), > 0, SLAB_TEMPORARY, NULL); > - if (jbd2_revoke_table_cache && jbd2_revoke_table_cache) { > + if (jbd2_revoke_record_cache && jbd2_revoke_table_cache) { > return 0; > } else { > jbd2_journal_destroy_revoke_caches(); > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html