From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sven Schnelle Subject: [PATCH] [PATCH] afs: add missing up_write() on return Date: Wed, 2 Apr 2008 07:50:07 +0200 Message-ID: <1207115407-7294-1-git-send-email-svens@stackframe.org> References: <26826.1207085641@redhat.com> Cc: linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org, svens@stackframe.org To: dhowells@redhat.com Return-path: Received: from smtp.duncanthrax.net ([89.31.1.170]:51408 "EHLO smtp.duncanthrax.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750740AbYDBFu1 (ORCPT ); Wed, 2 Apr 2008 01:50:27 -0400 In-Reply-To: <26826.1207085641@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: if afs_cell_alloc() fails, afs_cells_sem doesn't get unlocked, which leads to a deadlock. Unlock it before returning. Signed-off-by: Sven Schnelle --- fs/afs/cell.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/afs/cell.c b/fs/afs/cell.c index 788865d..584bb0f 100644 --- a/fs/afs/cell.c +++ b/fs/afs/cell.c @@ -138,6 +138,7 @@ struct afs_cell *afs_cell_create(const char *name, char *vllist) cell = afs_cell_alloc(name, vllist); if (IS_ERR(cell)) { _leave(" = %ld", PTR_ERR(cell)); + up_write(&afs_cells_sem); return cell; } -- 1.5.4.5