From: Ian Kent <raven@themaw.net>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
autofs mailing list <autofs@linux.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] autofs4 - detect invalid direct mount requests
Date: Fri, 20 Jun 2008 21:12:12 +0800 [thread overview]
Message-ID: <1213967533.2971.98.camel@raven.themaw.net> (raw)
In-Reply-To: <x49iqw4tg63.fsf@segfault.boston.devel.redhat.com>
On Fri, 2008-06-20 at 09:00 -0400, Jeff Moyer wrote:
> Ian Kent <raven@themaw.net> writes:
>
> > autofs v5 dierct and offset mounts within an autofs filesystem are
> > triggered by existing autofs triger mounts so the mount point dentry
> > must be positive. If the mount point dentry is negative then the
> > trigger doesn't exist so we can return fail immediately.
>
> What are the conditions that lead us here in that case?
v5 doesn't need to get those dir/otherdir messages that we can't avoid
for v4.
Basically, attempts to access a non-existent directory in multi-mount
tree leads to a negative dentry being sent to the wait queue, but v5
direct and offset mounts must always have an existing (non-negative
dentry) directory upon which to mount. This is only relevant for
multi-mounts that don't have an explicit multi-mount root so that the
lookups occur within the autofs file system.
Sorry, I still can't think of a way to avoid this for v4.
Ian
next prev parent reply other threads:[~2008-06-20 13:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-20 5:13 [PATCH] autofs4 - detect invalid direct mount requests Ian Kent
2008-06-20 13:00 ` Jeff Moyer
2008-06-20 13:12 ` Ian Kent [this message]
2008-07-02 13:46 ` Ian Kent
2008-07-01 21:17 ` Andrew Morton
2008-07-02 8:59 ` Ian Kent
2008-07-02 13:42 ` Jeff Moyer
2008-07-02 13:50 ` Ian Kent
2008-07-02 16:54 ` Andrew Morton
2008-07-03 1:57 ` Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1213967533.2971.98.camel@raven.themaw.net \
--to=raven@themaw.net \
--cc=akpm@linux-foundation.org \
--cc=autofs@linux.kernel.org \
--cc=jmoyer@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).