From mboxrd@z Thu Jan 1 00:00:00 1970 From: Subrata Modak Subject: Re: [rfc patch 0/4] splice: cleanups and fixes Date: Mon, 23 Jun 2008 20:56:05 +0530 Message-ID: <1214234765.4719.99.camel@subratamodak.linux.ibm.com> References: <20080621154607.154640724@szeredi.hu> <1214068808.5607.3.camel@subratamodak.linux.ibm.com> Reply-To: subrata@linux.vnet.ibm.com Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: jens.axboe@oracle.com, linux-fsdevel@vger.kernel.org, ltp-list@lists.sourceforge.net To: Miklos Szeredi Return-path: Received: from e4.ny.us.ibm.com ([32.97.182.144]:35834 "EHLO e4.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756380AbYFWP0U (ORCPT ); Mon, 23 Jun 2008 11:26:20 -0400 Received: from d01relay07.pok.ibm.com (d01relay07.pok.ibm.com [9.56.227.147]) by e4.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id m5NFQHnM023852 for ; Mon, 23 Jun 2008 11:26:17 -0400 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d01relay07.pok.ibm.com (8.13.8/8.13.8/NCO v9.0) with ESMTP id m5NFQHoF880790 for ; Mon, 23 Jun 2008 11:26:17 -0400 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m5NFQ7n6016058 for ; Mon, 23 Jun 2008 09:26:07 -0600 In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi Miklos , On Sun, 2008-06-22 at 08:16 +0200, Miklos Szeredi wrote: > > In the backdrop of the changes in splice(), would you also like to help > > us in reviewing the existing testcase for splice() in LTP: > > > > http://ltp.cvs.sourceforge.net/ltp/ltp/testcases/kernel/syscalls/splice/, > > Well, there's probably lot more different tests that could be done: > > - splicing from various sources (socket, pipe, regular file) > - splicing to various sources (...) > - splicing in full page(s) > - splicing in partial page(s) > - filling the destination pipe (blocking/nonblocking) > - splicing in a big buffer (bigger than the pipe buffer) > - splicing out full buffers > - splicing out partial buffers > - splicing out multiple buffers > - splicing out more data then is in the pipe (blocking/nonblocking) > - parallel splicing (in and/or out) > Thanks for pointing out the areas that can be tested in addition to what is existing. The list is very comprehensive. I will see if i can get somebody to work on this. Will put you in CC for review. Hope you do not mind that. > And then there's vmsplice(), which I haven't even looked at. Yes, please do look into this and give us more feedback like the splice above. You can find it here: http://ltp.cvs.sourceforge.net/ltp/ltp/testcases/kernel/syscalls/vmsplice/. > > > It would also be great if you can send us some patch as well in the > > regard. > > Unfortunately this would be a much bigger project than the cleanup I > did on the kernel splice code, and I don't really have the time to do > it :( We appreciate the already feedback you have given us. Hope you will also help in future review of the testcases. Regards-- Subrata > > Miklos