From mboxrd@z Thu Jan 1 00:00:00 1970 From: Subrata Modak Subject: Re: [LTP] [rfc patch 0/4] splice: cleanups and fixes Date: Wed, 25 Jun 2008 18:47:08 +0530 Message-ID: <1214399828.10818.22.camel@subratamodak.linux.ibm.com> References: <20080621154607.154640724@szeredi.hu> <1214068808.5607.3.camel@subratamodak.linux.ibm.com> <1214234765.4719.99.camel@subratamodak.linux.ibm.com> Reply-To: subrata@linux.vnet.ibm.com Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, ltp-list@lists.sourceforge.net, jens.axboe@oracle.com To: Miklos Szeredi Return-path: Received: from e31.co.us.ibm.com ([32.97.110.149]:36145 "EHLO e31.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755809AbYFYNRO (ORCPT ); Wed, 25 Jun 2008 09:17:14 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e31.co.us.ibm.com (8.13.8/8.13.8) with ESMTP id m5PDHDhB012781 for ; Wed, 25 Jun 2008 09:17:13 -0400 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.0) with ESMTP id m5PDHDKk175806 for ; Wed, 25 Jun 2008 07:17:13 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m5PDHCXM024431 for ; Wed, 25 Jun 2008 07:17:13 -0600 In-Reply-To: <1214234765.4719.99.camel@subratamodak.linux.ibm.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, 2008-06-23 at 20:56 +0530, Subrata Modak wrote: > Hi Miklos , > > On Sun, 2008-06-22 at 08:16 +0200, Miklos Szeredi wrote: > > > In the backdrop of the changes in splice(), would you also like to help > > > us in reviewing the existing testcase for splice() in LTP: > > > > > > http://ltp.cvs.sourceforge.net/ltp/ltp/testcases/kernel/syscalls/splice/, > > > > Well, there's probably lot more different tests that could be done: > > > > - splicing from various sources (socket, pipe, regular file) > > - splicing to various sources (...) > > - splicing in full page(s) > > - splicing in partial page(s) > > - filling the destination pipe (blocking/nonblocking) > > - splicing in a big buffer (bigger than the pipe buffer) > > - splicing out full buffers > > - splicing out partial buffers > > - splicing out multiple buffers > > - splicing out more data then is in the pipe (blocking/nonblocking) > > - parallel splicing (in and/or out) > > > > Thanks for pointing out the areas that can be tested in addition to what > is existing. The list is very comprehensive. I will see if i can get > somebody to work on this. Will put you in CC for review. Hope you do not > mind that. > > > And then there's vmsplice(), which I haven't even looked at. > > Yes, please do look into this and give us more feedback like the splice > above. You can find it here: > > http://ltp.cvs.sourceforge.net/ltp/ltp/testcases/kernel/syscalls/vmsplice/. Hi Miklos, Would you also like to provide some wonderful feedback for the vmsplice() syscall test cases like the way you provided for the splice() test cases? Regards-- Subrata > > > > > > It would also be great if you can send us some patch as well in the > > > regard. > > > > Unfortunately this would be a much bigger project than the cleanup I > > did on the kernel splice code, and I don't really have the time to do > > it :( > > We appreciate the already feedback you have given us. Hope you will also > help in future review of the testcases. > > Regards-- > Subrata > > > > > Miklos > > > ------------------------------------------------------------------------- > Check out the new SourceForge.net Marketplace. > It's the best place to buy or sell services for > just about anything Open Source. > http://sourceforge.net/services/buy/index.php > _______________________________________________ > Ltp-list mailing list > Ltp-list@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/ltp-list