From mboxrd@z Thu Jan 1 00:00:00 1970 From: Subrata Modak Subject: Re: [rfc patch 0/4] splice: cleanups and fixes Date: Thu, 26 Jun 2008 13:04:38 +0530 Message-ID: <1214465694.5575.15.camel@subratamodak.linux.ibm.com> References: <20080621154607.154640724@szeredi.hu> <1214068808.5607.3.camel@subratamodak.linux.ibm.com> <1214234765.4719.99.camel@subratamodak.linux.ibm.com> <1214399828.10818.22.camel@subratamodak.linux.ibm.com> Reply-To: subrata-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, ltp-list-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Miklos Szeredi , "jens.axboe" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ltp-list-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: ltp-list-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org On Wed, 2008-06-25 at 16:00 +0200, Miklos Szeredi wrote: > > Would you also like to provide some wonderful feedback for the > > vmsplice() syscall test cases like the way you provided for the splice() > > test cases? > > I haven't looked at vmsplice() yet. I think Jens would be in a better > position to provide such feedback. Thanks Miklos. I would also request feedback from Jens as well. Hi Jens, Miklos has recently helped us review the spilce() syscall test cases in LTP, available at: http://ltp.cvs.sourceforge.net/ltp/ltp/testcases/kernel/syscalls/splice/ and has provided us valuable feedback on improvements of these test cases on the following lines: > > Well, there's probably lot more different tests that could be done: > > > > - splicing from various sources (socket, pipe, regular file) > > - splicing to various sources (...) > > - splicing in full page(s) > > - splicing in partial page(s) > > - filling the destination pipe (blocking/nonblocking) > > - splicing in a big buffer (bigger than the pipe buffer) > > - splicing out full buffers > > - splicing out partial buffers > > - splicing out multiple buffers > > - splicing out more data then is in the pipe (blocking/nonblocking) > > - parallel splicing (in and/or out) > > I would request you to kindly help us review the vmspilce() syscall test cases in LTP, and also give us review feedback and improvements on the same: http://ltp.cvs.sourceforge.net/ltp/ltp/testcases/kernel/syscalls/vmsplice/ Regards-- Subrata > > Thanks, > Miklos ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php