From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: AZFS file system proposal Date: Wed, 09 Jul 2008 19:23:34 +1000 Message-ID: <1215595414.8970.366.camel@pasglop> References: <20080618160629.6cd749a8@mercedes-benz.boeblingen.de.ibm.com> <200807011659.33413.arnd@arndb.de> <1215593918.8970.363.camel@pasglop> <20080709111402.5af92580@mercedes-benz.boeblingen.de.ibm.com> Reply-To: benh@kernel.crashing.org Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org, Arnd Bergmann To: Maxim Shchetynin Return-path: Received: from gate.crashing.org ([63.228.1.57]:52594 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751608AbYGIJYW (ORCPT ); Wed, 9 Jul 2008 05:24:22 -0400 In-Reply-To: <20080709111402.5af92580@mercedes-benz.boeblingen.de.ibm.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, 2008-07-09 at 11:14 +0200, Maxim Shchetynin wrote: > Am Wed, 09 Jul 2008 18:58:38 +1000 > schrieb Benjamin Herrenschmidt : > > > On Tue, 2008-07-01 at 16:59 +0200, Arnd Bergmann wrote: > > > I wouldn't hold up merging the file system for this problem, but > > > until it is solved, the Kconfig entry should probably have > > > a "depends on PPC". > > > > Better, use an ifdef for powerpc flags, and #else to pgprot_noncached. > > Thank you Ben. Then, how about this? > > azfs_mmap(struct file *file, struct vm_area_struct *vma) > { > ... > ... > ... > #ifdef CONFIG_PPC > pgprot_t page_prot; > #endif > ... > ... > ... > #ifdef CONFIG_PPC > page_prot = pgprot_val(vma->vm_page_prot); > page_prot |= (_PAGE_NO_CACHE | _PAGE_RW); > page_prot &= ~_PAGE_GUARDED; > vma->vm_page_prot = __pgprot(page_prot); > #else > vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot); > #endif > ... I'd rather do pgprot_t prot; #ifdef CONFIG_PPC prot = #else prot = pgprot_noncached(...) #endif vma->vm_page_prot = prot; To limit the number of ifdef's Cheers, Ben.