From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Woodhouse Subject: Re: [PATCH 1/5] [BLOCK] Add 'discard' request handling Date: Fri, 08 Aug 2008 12:29:57 +0100 Message-ID: <1218194997.12232.124.camel@pmac.infradead.org> References: <1217900716.3454.667.camel@pmac.infradead.org> <20080805114210.GW20055@kernel.dk> <1217953741.3454.784.camel@pmac.infradead.org> <1217957140.3454.800.camel@pmac.infradead.org> <1218014703.5111.35.camel@pmac.infradead.org> <20080807184155.GE20055@kernel.dk> <1218187995.12232.95.camel@pmac.infradead.org> <20080808103041.GM20055@kernel.dk> <1218192731.12232.110.camel@pmac.infradead.org> <20080808110934.GO20055@kernel.dk> <20080808111829.GP20055@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Andrew Morton , Ric Wheeler , linux-fsdevel@vger.kernel.org, gilad@codefidence.com To: Jens Axboe Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:50639 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754854AbYHHLac (ORCPT ); Fri, 8 Aug 2008 07:30:32 -0400 In-Reply-To: <20080808111829.GP20055@kernel.dk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, 2008-08-08 at 13:18 +0200, Jens Axboe wrote: > Actually, my memory is a bit shot, since I got rid of ->issue_flush_fn > in the 2.6.24 cycle. So it's already gone It was q->prepare_flush_fn which the discard_fn is based on, and that's still there in the for-2.6.28 tree you just pointed me at. http://git.kernel.dk/?p=linux-2.6-block.git;a=blob;f=block/blk-barrier.c;h=a09ead19f9c5702a1ad76d709c54969176fe9e94;hb=6dc2b733b2f9605b48fdb7692fce5a3eafe241e4#l149 -- David Woodhouse Open Source Technology Centre David.Woodhouse@intel.com Intel Corporation