From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 1/5] [BLOCK] Add 'discard' request handling
Date: Fri, 08 Aug 2008 16:32:58 +0100
Message-ID: <1218209578.12232.177.camel@pmac.infradead.org>
References: <1217953741.3454.784.camel@pmac.infradead.org>
	 <1217957140.3454.800.camel@pmac.infradead.org>
	 <1218014703.5111.35.camel@pmac.infradead.org>
	 <20080807184155.GE20055@kernel.dk>
	 <1218187995.12232.95.camel@pmac.infradead.org>
	 <20080808103041.GM20055@kernel.dk>
	 <1218192731.12232.110.camel@pmac.infradead.org>
	 <20080808110934.GO20055@kernel.dk> <20080808111829.GP20055@kernel.dk>
	 <1218194997.12232.124.camel@pmac.infradead.org>
	 <20080808114409.GR20055@kernel.dk>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Ric Wheeler <ricwheeler@gmail.com>,
	linux-fsdevel@vger.kernel.org, gilad@codefidence.com
To: Jens Axboe <jens.axboe@oracle.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([18.85.46.34]:50756 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752105AbYHHPdf (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Fri, 8 Aug 2008 11:33:35 -0400
In-Reply-To: <20080808114409.GR20055@kernel.dk>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Fri, 2008-08-08 at 13:44 +0200, Jens Axboe wrote:
> +       if (err) {
> +               if (err == -EOPNOTSUPP)
> +                       set_bit(BIO_EOPNOTSUPP, &bio->bi_flags);
> +               clear_bit(BIO_UPTODATE, &bio->bi_flags);
> +       }

If we're going to do that, we should do it whether the caller provides
their own end_io function or not. So we should probably call their
->end_io function from ours. I'll store it in ->bi_private and do just
that.

-- 
dwmw2