linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Ric Wheeler <ricwheeler@gmail.com>,
	linux-fsdevel@vger.kernel.org, gilad@codefidence.com,
	matthew@wil.cx
Subject: [USERSPACE PATCH] blktrace: support discard requests
Date: Sun, 10 Aug 2008 11:35:49 +0100	[thread overview]
Message-ID: <1218364549.5063.36.camel@pmac.infradead.org> (raw)
In-Reply-To: <1218364148.5063.30.camel@pmac.infradead.org>

Add support for discard requests to blktrace userspace tools.

Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>

diff --git a/act_mask.c b/act_mask.c
index 40a4050..6632320 100644
--- a/act_mask.c
+++ b/act_mask.c
@@ -25,6 +25,7 @@ static struct mask_map mask_maps[] = {
 	DECLARE_MASK_MAP(PC),
 	DECLARE_MASK_MAP(AHEAD),
 	DECLARE_MASK_MAP(META),
+	DECLARE_MASK_MAP(DISCARD),
 };
 
 int find_mask_map(char *string)
diff --git a/blkparse_fmt.c b/blkparse_fmt.c
index 364f27c..83a8504 100644
--- a/blkparse_fmt.c
+++ b/blkparse_fmt.c
@@ -57,9 +57,12 @@ static inline void fill_rwbs(char *rwbs, struct blk_io_trace *t)
 	int b = t->action & BLK_TC_ACT(BLK_TC_BARRIER);
 	int s = t->action & BLK_TC_ACT(BLK_TC_SYNC);
 	int m = t->action & BLK_TC_ACT(BLK_TC_META);
+	int d = t->action & BLK_TC_ACT(BLK_TC_DISCARD);
 	int i = 0;
 
-	if (w)
+	if (d)
+		rwbs[i++] = 'D';
+	else if (w)
 		rwbs[i++] = 'W';
 	else if (t->bytes)
 		rwbs[i++] = 'R';
diff --git a/blkrawverify.c b/blkrawverify.c
index 82a435e..984dbff 100644
--- a/blkrawverify.c
+++ b/blkrawverify.c
@@ -49,6 +49,7 @@ static struct trace_info traces[] = {
 	TRACE_TO_STRING( BLK_TC_PC ),
 	TRACE_TO_STRING( BLK_TC_AHEAD ),
 	TRACE_TO_STRING( BLK_TC_META ),
+	TRACE_TO_STRING( BLK_TC_DISCARD ),
 };
 #define N_TRACES (sizeof(traces) / sizeof(struct trace_info))
 
diff --git a/blktrace_api.h b/blktrace_api.h
index 67720de..992850c 100644
--- a/blktrace_api.h
+++ b/blktrace_api.h
@@ -20,6 +20,7 @@ enum {
 	BLK_TC_NOTIFY	= 1 << 10,	/* special message */
 	BLK_TC_AHEAD	= 1 << 11,	/* readahead */
 	BLK_TC_META	= 1 << 12,	/* metadata */
+	BLK_TC_DISCARD	= 1 << 13,	/* discard requests */
 
 	BLK_TC_END	= 1 << 15,	/* only 16-bits, reminder */
 };

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@intel.com                              Intel Corporation




  reply	other threads:[~2008-08-10 10:36 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-09 16:26 [PATCH 0/7] Discard requests, v2 David Woodhouse
2008-08-09 16:29 ` [PATCH 1/7] [BLOCK] Fix typo causing compile error in blk_queue_bounce() David Woodhouse
2008-08-09 16:30 ` [PATCH 2/7] [BLOCK] Fix up comments about matching flags between bio and rq David Woodhouse
2008-08-09 16:30 ` [PATCH 3/7] [BLOCK] Add 'discard' request handling David Woodhouse
2008-08-09 20:39   ` OGAWA Hirofumi
2008-08-09 21:37     ` David Woodhouse
2008-08-10  6:32     ` David Woodhouse
2008-08-09 16:31 ` [PATCH 4/7] [FAT] Let the block device know when sectors can be discarded David Woodhouse
2008-08-09 16:32 ` [PATCH 5/7] [MTD] Support 'discard sectors' operation in translation layer support core David Woodhouse
2008-08-09 16:33 ` [PATCH 6/7] [MTD] [FTL] Support 'discard sectors' operation David Woodhouse
2008-08-09 16:33 ` [PATCH 7/7] [BLOCK] Allow elevators to sort/merge discard requests David Woodhouse
2008-10-03 20:29   ` Andrew Morton
2008-10-07 12:07     ` Jens Axboe
2008-08-09 22:48 ` [PATCH 0/7] Discard requests, v2 OGAWA Hirofumi
2008-08-10 10:25   ` David Woodhouse
2008-08-10 16:37     ` Jamie Lokier
2008-08-10 17:55       ` OGAWA Hirofumi
2008-08-10 20:07         ` David Woodhouse
2008-08-10 21:40           ` OGAWA Hirofumi
2008-08-11  9:40             ` David Woodhouse
2008-08-11 10:25               ` OGAWA Hirofumi
2008-08-11 13:17                 ` David Woodhouse
2008-08-11 14:21                   ` OGAWA Hirofumi
2008-08-10 10:29 ` [PATCH 8/7] blktrace: support discard requests David Woodhouse
2008-08-10 10:35   ` David Woodhouse [this message]
2008-08-15  8:43     ` [USERSPACE PATCH] " Jens Axboe
2008-08-15  9:01       ` David Woodhouse
2008-08-15  9:08         ` Jens Axboe
2008-08-10 10:41   ` [PATCH 8/7] " David Woodhouse
2008-08-13 11:17     ` Jens Axboe
2008-08-10 11:48 ` [PATCH 9/7] blktrace: simplify flags handling in __blk_add_trace David Woodhouse
2008-08-10 11:50   ` David Woodhouse
2008-08-11 15:11 ` [PATCH 10/7] [BLOCK] Add BLKDISCARD ioctl to allow userspace to discard sectors David Woodhouse
2008-08-11 18:27   ` Matthew Wilcox
2008-08-11 20:52   ` David Woodhouse
2008-08-12  9:14 ` [PATCH 0/7] Discard requests, v2 Jens Axboe
2008-08-12 10:00   ` David Woodhouse
2008-08-12 10:54     ` Jens Axboe
2008-08-12 11:16       ` David Woodhouse
2008-08-12 12:19         ` David Woodhouse
2008-08-12 12:53           ` Jens Axboe
2008-08-12 13:04             ` David Woodhouse
2008-08-12 15:47               ` David Woodhouse
2008-08-12 18:04                 ` Jamie Lokier
2008-08-13 10:22                   ` David Woodhouse
2008-08-13 12:19                     ` Jamie Lokier
2008-08-13 12:26                       ` David Woodhouse
2008-08-13 11:15                 ` Jens Axboe
2008-08-13 11:23                   ` David Woodhouse
2008-08-13 11:32                     ` Jens Axboe
2008-08-13 11:34                       ` David Woodhouse
2008-08-13 12:07                         ` David Woodhouse
2008-08-14  7:49                         ` Jens Axboe
2008-08-14  7:52                           ` David Woodhouse
2008-08-14  7:25                       ` David Woodhouse
2008-08-14  7:33                         ` Stephen Rothwell
2008-08-14  7:37                           ` David Woodhouse
2008-08-14  7:42                           ` Jens Axboe
2008-08-14  7:46                             ` Stephen Rothwell
2008-08-12 18:10     ` Jamie Lokier
2008-08-13 10:20       ` David Woodhouse
2008-08-12 11:42   ` Matthew Wilcox
2008-08-12 11:46     ` David Woodhouse
2008-08-12 19:53   ` OGAWA Hirofumi
2008-08-12 20:11     ` OGAWA Hirofumi
2008-08-13 11:39 ` [PATCH 11/7] Kill REQ_TYPE_FLUSH David Woodhouse
2008-08-13 11:58   ` Geert Uytterhoeven
2008-08-13 12:43     ` David Woodhouse
2008-08-13 15:40   ` Jens Axboe
2008-08-13 15:46     ` David Woodhouse
2008-08-16 17:08 ` [PATCH 0/2] MMC discard support (was [PATCH 0/7] Discard requests, v2) Pierre Ossman
2008-08-16 17:11   ` [PATCH 1/2] mmc_block: factor out the mmc request handling Pierre Ossman
2008-08-16 17:12   ` [PATCH 2/2] mmc_block: erase discarded blocks Pierre Ossman
2008-08-16 17:38   ` [PATCH 0/2] MMC discard support (was [PATCH 0/7] Discard requests, v2) David Woodhouse
2008-08-16 17:51     ` Pierre Ossman
2008-08-22  9:24   ` Jens Axboe
2008-08-22  9:45     ` David Woodhouse
2008-08-22 10:50       ` Jens Axboe
2008-08-22 10:58         ` David Woodhouse
2008-08-22 11:11           ` Pierre Ossman
2008-08-22 11:19             ` Jens Axboe
2008-08-22 11:13     ` Pierre Ossman
2008-08-22 11:20       ` Jens Axboe
2008-08-22 14:49         ` OGAWA Hirofumi
2008-08-22 23:02           ` Pierre Ossman
2008-08-22 23:59             ` OGAWA Hirofumi
2008-08-24 11:23               ` Pierre Ossman
2008-08-24 13:39                 ` OGAWA Hirofumi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1218364549.5063.36.camel@pmac.infradead.org \
    --to=dwmw2@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=gilad@codefidence.com \
    --cc=jens.axboe@oracle.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=ricwheeler@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).