linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Ric Wheeler <ricwheeler@gmail.com>,
	linux-fsdevel@vger.kernel.org, gilad@codefidence.com,
	matthew@wil.cx
Subject: [PATCH 10/7] [BLOCK] Add BLKDISCARD ioctl to allow userspace to discard sectors
Date: Mon, 11 Aug 2008 16:11:12 +0100	[thread overview]
Message-ID: <1218467472.2977.9.camel@pmac.infradead.org> (raw)
In-Reply-To: <1218299181.26926.88.camel@pmac.infradead.org>

We may well want mkfs tools to use this to mark the whole device as
unwanted before they format it, for example.

The ioctl takes a pair of uint64_ts, which are start offset and length
in _bytes_. Although at the moment it might make sense for them both to
be in 512-byte sectors, I don't want to limit the ABI to that.

Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
---
 block/compat_ioctl.c |    1 +
 block/ioctl.c        |   74 ++++++++++++++++++++++++++++++++++++++++++++++++++
 include/linux/fs.h   |    1 +
 3 files changed, 76 insertions(+), 0 deletions(-)

diff --git a/block/compat_ioctl.c b/block/compat_ioctl.c
index c23177e..1e559fb 100644
--- a/block/compat_ioctl.c
+++ b/block/compat_ioctl.c
@@ -788,6 +788,7 @@ long compat_blkdev_ioctl(struct file *file, unsigned cmd, unsigned long arg)
 		return compat_hdio_getgeo(disk, bdev, compat_ptr(arg));
 	case BLKFLSBUF:
 	case BLKROSET:
+	case BLKDISCARD:
 	/*
 	 * the ones below are implemented in blkdev_locked_ioctl,
 	 * but we call blkdev_ioctl, which gets the lock for us
diff --git a/block/ioctl.c b/block/ioctl.c
index 77185e5..8193fbb 100644
--- a/block/ioctl.c
+++ b/block/ioctl.c
@@ -111,6 +111,69 @@ static int blkdev_reread_part(struct block_device *bdev)
 	return res;
 }
 
+static void blk_ioc_discard_endio(struct bio *bio, int err)
+{
+	if (err) {
+		if (err == -EOPNOTSUPP)
+			set_bit(BIO_EOPNOTSUPP, &bio->bi_flags);
+		clear_bit(BIO_UPTODATE, &bio->bi_flags);
+	}
+	complete(bio->bi_private);
+}
+
+static int blk_ioctl_discard(struct block_device *bdev, uint64_t start,
+			     uint64_t len)
+{
+	struct request_queue *q = bdev_get_queue(bdev);
+	int ret = 0;
+
+	if (start & 511)
+		return -EINVAL;
+	if (len & 511)
+		return -EINVAL;
+	start >>= 9;
+	len >>= 9;
+
+	if (start + len > (bdev->bd_inode->i_size >> 9))
+		return -EINVAL;
+
+	if (!q->prepare_discard_fn)
+		return -EOPNOTSUPP;
+
+	while (len && !ret) {
+		DECLARE_COMPLETION_ONSTACK(wait);
+		struct bio *bio;
+
+		bio = bio_alloc(GFP_KERNEL, 0);
+		if (!bio)
+			return -ENOMEM;
+
+		bio->bi_end_io = blk_ioc_discard_endio;
+		bio->bi_bdev = bdev;
+		bio->bi_private = &wait;
+		bio->bi_sector = start;
+
+		if (len > q->max_hw_sectors) {
+			bio->bi_size = q->max_hw_sectors << 9;
+			len -= q->max_hw_sectors;
+			start += q->max_hw_sectors;
+		} else {
+			bio->bi_size = len << 9;
+			len = 0;
+		}
+		submit_bio(WRITE_DISCARD, bio);
+
+		wait_for_completion(&wait);
+
+		if (bio_flagged(bio, BIO_EOPNOTSUPP))
+			ret = -EOPNOTSUPP;
+		else if (!bio_flagged(bio, BIO_UPTODATE))
+			ret = -EIO;
+		bio_put(bio);
+	}
+	return ret;
+}
+
 static int put_ushort(unsigned long arg, unsigned short val)
 {
 	return put_user(val, (unsigned short __user *)arg);
@@ -258,6 +321,17 @@ int blkdev_ioctl(struct inode *inode, struct file *file, unsigned cmd,
 		set_device_ro(bdev, n);
 		unlock_kernel();
 		return 0;
+
+	case BLKDISCARD: {
+		uint64_t start, len;
+
+		if (get_user(start, (uint64_t __user *)(arg)) ||
+		    get_user(len, (uint64_t __user *)(arg+8)))
+			return -EFAULT;
+
+		return blk_ioctl_discard(bdev, start, len);
+	}
+
 	case HDIO_GETGEO: {
 		struct hd_geometry geo;
 
diff --git a/include/linux/fs.h b/include/linux/fs.h
index eb01313..88358ca 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -223,6 +223,7 @@ extern int dir_notify_enable;
 #define BLKTRACESTART _IO(0x12,116)
 #define BLKTRACESTOP _IO(0x12,117)
 #define BLKTRACETEARDOWN _IO(0x12,118)
+#define BLKDISCARD _IO(0x12,119)
 
 #define BMAP_IOCTL 1		/* obsolete - kept for compatibility */
 #define FIBMAP	   _IO(0x00,1)	/* bmap access */
-- 
1.5.5.1


-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@intel.com                              Intel Corporation




  parent reply	other threads:[~2008-08-11 15:11 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-09 16:26 [PATCH 0/7] Discard requests, v2 David Woodhouse
2008-08-09 16:29 ` [PATCH 1/7] [BLOCK] Fix typo causing compile error in blk_queue_bounce() David Woodhouse
2008-08-09 16:30 ` [PATCH 2/7] [BLOCK] Fix up comments about matching flags between bio and rq David Woodhouse
2008-08-09 16:30 ` [PATCH 3/7] [BLOCK] Add 'discard' request handling David Woodhouse
2008-08-09 20:39   ` OGAWA Hirofumi
2008-08-09 21:37     ` David Woodhouse
2008-08-10  6:32     ` David Woodhouse
2008-08-09 16:31 ` [PATCH 4/7] [FAT] Let the block device know when sectors can be discarded David Woodhouse
2008-08-09 16:32 ` [PATCH 5/7] [MTD] Support 'discard sectors' operation in translation layer support core David Woodhouse
2008-08-09 16:33 ` [PATCH 6/7] [MTD] [FTL] Support 'discard sectors' operation David Woodhouse
2008-08-09 16:33 ` [PATCH 7/7] [BLOCK] Allow elevators to sort/merge discard requests David Woodhouse
2008-10-03 20:29   ` Andrew Morton
2008-10-07 12:07     ` Jens Axboe
2008-08-09 22:48 ` [PATCH 0/7] Discard requests, v2 OGAWA Hirofumi
2008-08-10 10:25   ` David Woodhouse
2008-08-10 16:37     ` Jamie Lokier
2008-08-10 17:55       ` OGAWA Hirofumi
2008-08-10 20:07         ` David Woodhouse
2008-08-10 21:40           ` OGAWA Hirofumi
2008-08-11  9:40             ` David Woodhouse
2008-08-11 10:25               ` OGAWA Hirofumi
2008-08-11 13:17                 ` David Woodhouse
2008-08-11 14:21                   ` OGAWA Hirofumi
2008-08-10 10:29 ` [PATCH 8/7] blktrace: support discard requests David Woodhouse
2008-08-10 10:35   ` [USERSPACE PATCH] " David Woodhouse
2008-08-15  8:43     ` Jens Axboe
2008-08-15  9:01       ` David Woodhouse
2008-08-15  9:08         ` Jens Axboe
2008-08-10 10:41   ` [PATCH 8/7] " David Woodhouse
2008-08-13 11:17     ` Jens Axboe
2008-08-10 11:48 ` [PATCH 9/7] blktrace: simplify flags handling in __blk_add_trace David Woodhouse
2008-08-10 11:50   ` David Woodhouse
2008-08-11 15:11 ` David Woodhouse [this message]
2008-08-11 18:27   ` [PATCH 10/7] [BLOCK] Add BLKDISCARD ioctl to allow userspace to discard sectors Matthew Wilcox
2008-08-11 20:52   ` David Woodhouse
2008-08-12  9:14 ` [PATCH 0/7] Discard requests, v2 Jens Axboe
2008-08-12 10:00   ` David Woodhouse
2008-08-12 10:54     ` Jens Axboe
2008-08-12 11:16       ` David Woodhouse
2008-08-12 12:19         ` David Woodhouse
2008-08-12 12:53           ` Jens Axboe
2008-08-12 13:04             ` David Woodhouse
2008-08-12 15:47               ` David Woodhouse
2008-08-12 18:04                 ` Jamie Lokier
2008-08-13 10:22                   ` David Woodhouse
2008-08-13 12:19                     ` Jamie Lokier
2008-08-13 12:26                       ` David Woodhouse
2008-08-13 11:15                 ` Jens Axboe
2008-08-13 11:23                   ` David Woodhouse
2008-08-13 11:32                     ` Jens Axboe
2008-08-13 11:34                       ` David Woodhouse
2008-08-13 12:07                         ` David Woodhouse
2008-08-14  7:49                         ` Jens Axboe
2008-08-14  7:52                           ` David Woodhouse
2008-08-14  7:25                       ` David Woodhouse
2008-08-14  7:33                         ` Stephen Rothwell
2008-08-14  7:37                           ` David Woodhouse
2008-08-14  7:42                           ` Jens Axboe
2008-08-14  7:46                             ` Stephen Rothwell
2008-08-12 18:10     ` Jamie Lokier
2008-08-13 10:20       ` David Woodhouse
2008-08-12 11:42   ` Matthew Wilcox
2008-08-12 11:46     ` David Woodhouse
2008-08-12 19:53   ` OGAWA Hirofumi
2008-08-12 20:11     ` OGAWA Hirofumi
2008-08-13 11:39 ` [PATCH 11/7] Kill REQ_TYPE_FLUSH David Woodhouse
2008-08-13 11:58   ` Geert Uytterhoeven
2008-08-13 12:43     ` David Woodhouse
2008-08-13 15:40   ` Jens Axboe
2008-08-13 15:46     ` David Woodhouse
2008-08-16 17:08 ` [PATCH 0/2] MMC discard support (was [PATCH 0/7] Discard requests, v2) Pierre Ossman
2008-08-16 17:11   ` [PATCH 1/2] mmc_block: factor out the mmc request handling Pierre Ossman
2008-08-16 17:12   ` [PATCH 2/2] mmc_block: erase discarded blocks Pierre Ossman
2008-08-16 17:38   ` [PATCH 0/2] MMC discard support (was [PATCH 0/7] Discard requests, v2) David Woodhouse
2008-08-16 17:51     ` Pierre Ossman
2008-08-22  9:24   ` Jens Axboe
2008-08-22  9:45     ` David Woodhouse
2008-08-22 10:50       ` Jens Axboe
2008-08-22 10:58         ` David Woodhouse
2008-08-22 11:11           ` Pierre Ossman
2008-08-22 11:19             ` Jens Axboe
2008-08-22 11:13     ` Pierre Ossman
2008-08-22 11:20       ` Jens Axboe
2008-08-22 14:49         ` OGAWA Hirofumi
2008-08-22 23:02           ` Pierre Ossman
2008-08-22 23:59             ` OGAWA Hirofumi
2008-08-24 11:23               ` Pierre Ossman
2008-08-24 13:39                 ` OGAWA Hirofumi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1218467472.2977.9.camel@pmac.infradead.org \
    --to=dwmw2@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=gilad@codefidence.com \
    --cc=jens.axboe@oracle.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=ricwheeler@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).