From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Woodhouse Subject: Re: [PATCH 0/7] Discard requests, v2 Date: Tue, 12 Aug 2008 16:47:34 +0100 Message-ID: <1218556054.2977.188.camel@pmac.infradead.org> References: <1218299181.26926.88.camel@pmac.infradead.org> <20080812091446.GF20055@kernel.dk> <1218535205.2977.131.camel@pmac.infradead.org> <20080812105428.GG20055@kernel.dk> <1218539797.2977.147.camel@pmac.infradead.org> <1218543544.2977.158.camel@pmac.infradead.org> <20080812125315.GH20055@kernel.dk> <1218546257.2977.167.camel@pmac.infradead.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Andrew Morton , Ric Wheeler , linux-fsdevel@vger.kernel.org, gilad@codefidence.com, matthew@wil.cx To: Jens Axboe Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:56119 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751799AbYHLPsO (ORCPT ); Tue, 12 Aug 2008 11:48:14 -0400 In-Reply-To: <1218546257.2977.167.camel@pmac.infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, 2008-08-12 at 14:04 +0100, David Woodhouse wrote: > > Or just match the check before -EOPNOTSUPP with bio_has_data(), > > since it only applies to a barrier that carries data. > > Like this, you mean? Empty barriers don't get to there? Seems to work, although I'm somewhat dubious about it. Still, if you're happy that it's correct and you really prefer it that way, then I can commit it. Anything else I need to address before you pull the tree? Any comment on the BLKDISCARD ioctl? I've left that one using the non-barrier version since it's waiting for it anyway, and shouldn't be happening concurrently with anything else. (http://,git://} git.infradead.org/users/dwmw2/discard-2.6.git -- David Woodhouse Open Source Technology Centre David.Woodhouse@intel.com Intel Corporation