linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Ric Wheeler <ricwheeler@gmail.com>,
	linux-fsdevel@vger.kernel.org, gilad@codefidence.com,
	matthew@wil.cx, FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
	Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Subject: [PATCH 11/7] Kill REQ_TYPE_FLUSH
Date: Wed, 13 Aug 2008 12:39:54 +0100	[thread overview]
Message-ID: <1218627594.2977.273.camel@pmac.infradead.org> (raw)
In-Reply-To: <1218299181.26926.88.camel@pmac.infradead.org>

It was only used by ps3disk, and it should probably have been
REQ_TYPE_LINUX_BLOCK + REQ_LB_OP_FLUSH.

Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
---
 drivers/block/ps3disk.c |    9 ++++++---
 include/linux/blkdev.h  |    1 -
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/block/ps3disk.c b/drivers/block/ps3disk.c
index d797e20..4b0d6c7 100644
--- a/drivers/block/ps3disk.c
+++ b/drivers/block/ps3disk.c
@@ -199,7 +199,8 @@ static void ps3disk_do_request(struct ps3_storage_device *dev,
 		if (blk_fs_request(req)) {
 			if (ps3disk_submit_request_sg(dev, req))
 				break;
-		} else if (req->cmd_type == REQ_TYPE_FLUSH) {
+		} else if (req->cmd_type == REQ_TYPE_LINUX_BLOCK &&
+			   req->cmd[0] == REQ_LB_OP_FLUSH) {
 			if (ps3disk_submit_flush_request(dev, req))
 				break;
 		} else {
@@ -257,7 +258,8 @@ static irqreturn_t ps3disk_interrupt(int irq, void *data)
 		return IRQ_HANDLED;
 	}
 
-	if (req->cmd_type == REQ_TYPE_FLUSH) {
+	if (req->cmd_type == REQ_TYPE_LINUX_BLOCK &&
+	    req->cmd[0] == REQ_LB_OP_FLUSH) {
 		read = 0;
 		num_sectors = req->hard_cur_sectors;
 		op = "flush";
@@ -405,7 +407,8 @@ static void ps3disk_prepare_flush(struct request_queue *q, struct request *req)
 
 	dev_dbg(&dev->sbd.core, "%s:%u\n", __func__, __LINE__);
 
-	req->cmd_type = REQ_TYPE_FLUSH;
+	req->cmd_type = REQ_TYPE_LINUX_BLOCK;
+	req->cmd[0] = REQ_LB_OP_FLUSH;
 }
 
 static unsigned long ps3disk_mask;
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 293a71a..a0fa413 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -54,7 +54,6 @@ enum rq_cmd_type_bits {
 	REQ_TYPE_PM_SUSPEND,		/* suspend request */
 	REQ_TYPE_PM_RESUME,		/* resume request */
 	REQ_TYPE_PM_SHUTDOWN,		/* shutdown request */
-	REQ_TYPE_FLUSH,			/* flush request */
 	REQ_TYPE_SPECIAL,		/* driver defined type */
 	REQ_TYPE_LINUX_BLOCK,		/* generic block layer message */
 	/*
-- 
1.5.5.1

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@intel.com                              Intel Corporation




  parent reply	other threads:[~2008-08-13 11:40 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-09 16:26 [PATCH 0/7] Discard requests, v2 David Woodhouse
2008-08-09 16:29 ` [PATCH 1/7] [BLOCK] Fix typo causing compile error in blk_queue_bounce() David Woodhouse
2008-08-09 16:30 ` [PATCH 2/7] [BLOCK] Fix up comments about matching flags between bio and rq David Woodhouse
2008-08-09 16:30 ` [PATCH 3/7] [BLOCK] Add 'discard' request handling David Woodhouse
2008-08-09 20:39   ` OGAWA Hirofumi
2008-08-09 21:37     ` David Woodhouse
2008-08-10  6:32     ` David Woodhouse
2008-08-09 16:31 ` [PATCH 4/7] [FAT] Let the block device know when sectors can be discarded David Woodhouse
2008-08-09 16:32 ` [PATCH 5/7] [MTD] Support 'discard sectors' operation in translation layer support core David Woodhouse
2008-08-09 16:33 ` [PATCH 6/7] [MTD] [FTL] Support 'discard sectors' operation David Woodhouse
2008-08-09 16:33 ` [PATCH 7/7] [BLOCK] Allow elevators to sort/merge discard requests David Woodhouse
2008-10-03 20:29   ` Andrew Morton
2008-10-07 12:07     ` Jens Axboe
2008-08-09 22:48 ` [PATCH 0/7] Discard requests, v2 OGAWA Hirofumi
2008-08-10 10:25   ` David Woodhouse
2008-08-10 16:37     ` Jamie Lokier
2008-08-10 17:55       ` OGAWA Hirofumi
2008-08-10 20:07         ` David Woodhouse
2008-08-10 21:40           ` OGAWA Hirofumi
2008-08-11  9:40             ` David Woodhouse
2008-08-11 10:25               ` OGAWA Hirofumi
2008-08-11 13:17                 ` David Woodhouse
2008-08-11 14:21                   ` OGAWA Hirofumi
2008-08-10 10:29 ` [PATCH 8/7] blktrace: support discard requests David Woodhouse
2008-08-10 10:35   ` [USERSPACE PATCH] " David Woodhouse
2008-08-15  8:43     ` Jens Axboe
2008-08-15  9:01       ` David Woodhouse
2008-08-15  9:08         ` Jens Axboe
2008-08-10 10:41   ` [PATCH 8/7] " David Woodhouse
2008-08-13 11:17     ` Jens Axboe
2008-08-10 11:48 ` [PATCH 9/7] blktrace: simplify flags handling in __blk_add_trace David Woodhouse
2008-08-10 11:50   ` David Woodhouse
2008-08-11 15:11 ` [PATCH 10/7] [BLOCK] Add BLKDISCARD ioctl to allow userspace to discard sectors David Woodhouse
2008-08-11 18:27   ` Matthew Wilcox
2008-08-11 20:52   ` David Woodhouse
2008-08-12  9:14 ` [PATCH 0/7] Discard requests, v2 Jens Axboe
2008-08-12 10:00   ` David Woodhouse
2008-08-12 10:54     ` Jens Axboe
2008-08-12 11:16       ` David Woodhouse
2008-08-12 12:19         ` David Woodhouse
2008-08-12 12:53           ` Jens Axboe
2008-08-12 13:04             ` David Woodhouse
2008-08-12 15:47               ` David Woodhouse
2008-08-12 18:04                 ` Jamie Lokier
2008-08-13 10:22                   ` David Woodhouse
2008-08-13 12:19                     ` Jamie Lokier
2008-08-13 12:26                       ` David Woodhouse
2008-08-13 11:15                 ` Jens Axboe
2008-08-13 11:23                   ` David Woodhouse
2008-08-13 11:32                     ` Jens Axboe
2008-08-13 11:34                       ` David Woodhouse
2008-08-13 12:07                         ` David Woodhouse
2008-08-14  7:49                         ` Jens Axboe
2008-08-14  7:52                           ` David Woodhouse
2008-08-14  7:25                       ` David Woodhouse
2008-08-14  7:33                         ` Stephen Rothwell
2008-08-14  7:37                           ` David Woodhouse
2008-08-14  7:42                           ` Jens Axboe
2008-08-14  7:46                             ` Stephen Rothwell
2008-08-12 18:10     ` Jamie Lokier
2008-08-13 10:20       ` David Woodhouse
2008-08-12 11:42   ` Matthew Wilcox
2008-08-12 11:46     ` David Woodhouse
2008-08-12 19:53   ` OGAWA Hirofumi
2008-08-12 20:11     ` OGAWA Hirofumi
2008-08-13 11:39 ` David Woodhouse [this message]
2008-08-13 11:58   ` [PATCH 11/7] Kill REQ_TYPE_FLUSH Geert Uytterhoeven
2008-08-13 12:43     ` David Woodhouse
2008-08-13 15:40   ` Jens Axboe
2008-08-13 15:46     ` David Woodhouse
2008-08-16 17:08 ` [PATCH 0/2] MMC discard support (was [PATCH 0/7] Discard requests, v2) Pierre Ossman
2008-08-16 17:11   ` [PATCH 1/2] mmc_block: factor out the mmc request handling Pierre Ossman
2008-08-16 17:12   ` [PATCH 2/2] mmc_block: erase discarded blocks Pierre Ossman
2008-08-16 17:38   ` [PATCH 0/2] MMC discard support (was [PATCH 0/7] Discard requests, v2) David Woodhouse
2008-08-16 17:51     ` Pierre Ossman
2008-08-22  9:24   ` Jens Axboe
2008-08-22  9:45     ` David Woodhouse
2008-08-22 10:50       ` Jens Axboe
2008-08-22 10:58         ` David Woodhouse
2008-08-22 11:11           ` Pierre Ossman
2008-08-22 11:19             ` Jens Axboe
2008-08-22 11:13     ` Pierre Ossman
2008-08-22 11:20       ` Jens Axboe
2008-08-22 14:49         ` OGAWA Hirofumi
2008-08-22 23:02           ` Pierre Ossman
2008-08-22 23:59             ` OGAWA Hirofumi
2008-08-24 11:23               ` Pierre Ossman
2008-08-24 13:39                 ` OGAWA Hirofumi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1218627594.2977.273.camel@pmac.infradead.org \
    --to=dwmw2@infradead.org \
    --cc=Geert.Uytterhoeven@sonycom.com \
    --cc=akpm@linux-foundation.org \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=gilad@codefidence.com \
    --cc=jens.axboe@oracle.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=ricwheeler@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).