From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Woodhouse Subject: Re: [PATCH 0/2] MMC discard support (was [PATCH 0/7] Discard requests, v2) Date: Fri, 22 Aug 2008 10:45:02 +0100 Message-ID: <1219398302.9583.21.camel@pmac.infradead.org> References: <1218299181.26926.88.camel@pmac.infradead.org> <20080816190858.4d150ea1@mjolnir.drzeus.cx> <20080822092448.GC20055@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Pierre Ossman , linux-fsdevel@vger.kernel.org To: Jens Axboe Return-path: Received: from casper.infradead.org ([85.118.1.10]:45996 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753258AbYHVJpO (ORCPT ); Fri, 22 Aug 2008 05:45:14 -0400 In-Reply-To: <20080822092448.GC20055@kernel.dk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, 2008-08-22 at 11:24 +0200, Jens Axboe wrote: > I agree with that, the thought did cross my mind earlier as well. I > committed something like the below (in two patches). But there _are_ limits on how many sectors can be discarded in a single operation. For ATA 'Trim' I think it's 65536? Do we want to force the drivers to translate a single request into multiple actual commands? I suspect we need a separate 'max_discard_sectors' field. -- David Woodhouse Open Source Technology Centre David.Woodhouse@intel.com Intel Corporation