From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Woodhouse Subject: Re: [PATCH] UBIFS: fill f_fsid Date: Wed, 03 Sep 2008 11:14:36 +0100 Message-ID: <1220436876.2985.82.camel@pmac.infradead.org> References: <1220194366-12731-1-git-send-email-dedekind@infradead.org> <1220194366-12731-13-git-send-email-dedekind@infradead.org> <1220262187.2982.58.camel@pmac.infradead.org> <1220435073.4036.41.camel@sauron> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Adrian Hunter To: dedekind@infradead.org Return-path: Received: from casper.infradead.org ([85.118.1.10]:47511 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751664AbYICKOk (ORCPT ); Wed, 3 Sep 2008 06:14:40 -0400 In-Reply-To: <1220435073.4036.41.camel@sauron> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, 2008-09-03 at 12:44 +0300, Artem Bityutskiy wrote: > On Mon, 2008-09-01 at 10:43 +0100, David Woodhouse wrote: > > For btrfs I xor the first 64 bits with the second 64 bits, and put > > _that_ into f_fsid. You're just putting the first 64 bits in and > > ignoring the second 64 bits. Neither is really _better_ than the > other; > > you just alter the circumstances in which you get collisions. But I > > suppose we might as well be consistent about how we do it? > > Like this? Yeah, that's what ext[234] and btrfs do. -- David Woodhouse Open Source Technology Centre David.Woodhouse@intel.com Intel Corporation