linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Duane Griffin" <duaneg@dghda.com>
To: linux-kernel@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Evgeniy Dushistov <dushistov@mail.ru>
Subject: [PATCH 0/8, v3] ensure symlinks are NUL-terminated
Date: Tue, 16 Dec 2008 15:51:52 +0000	[thread overview]
Message-ID: <1229442720-31056-1-git-send-email-duaneg@dghda.com> (raw)

These patches fix potential bugs associated with link target handling by
NUL-terminating names read from disk.

This is version 3 of these patches. It fixes the bug, pointed out by Al Viro
and Evgeniy Dushistov, that i_size was not being validated. In order to
facilitate this it introduces a helper function for terminating the link name,
as suggested by Al.

diffstat:
 fs/ext2/inode.c          |    7 +++++--
 fs/ext3/inode.c          |    7 +++++--
 fs/ext4/inode.c          |    7 +++++--
 fs/freevxfs/vxfs_inode.c |    4 +++-
 fs/namei.c               |    7 +++++--
 fs/sysv/inode.c          |    6 +++++-
 fs/ufs/inode.c           |    8 ++++++--
 include/linux/namei.h    |    5 +++++
 8 files changed, 39 insertions(+), 12 deletions(-)

             reply	other threads:[~2008-12-16 15:51 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-16 15:51 Duane Griffin [this message]
2008-12-16 15:51 ` [PATCH] vfs: introduce helper function to safely NUL-terminate symlinks Duane Griffin
2008-12-16 15:51   ` [PATCH] vfs: ensure page symlinks are NUL-terminated Duane Griffin
2008-12-16 15:51     ` [PATCH] ext2: ensure fast " Duane Griffin
2008-12-16 15:51       ` [PATCH] ext3: " Duane Griffin
2008-12-16 15:51         ` [PATCH] ext4: " Duane Griffin
2008-12-16 15:51           ` [PATCH] ufs: " Duane Griffin
2008-12-16 15:51             ` [PATCH] sysv: " Duane Griffin
2008-12-16 15:52               ` [PATCH] freevxfs: " Duane Griffin
2008-12-16 19:40             ` [PATCH] ufs: " Evgeniy Dushistov
2008-12-16 23:18               ` Duane Griffin
2008-12-27 12:22                 ` Evgeniy Dushistov
2008-12-16 23:46           ` [PATCH] vfs: introduce helper function to safely NUL-terminate symlinks Andreas Dilger
2008-12-17  0:26             ` Duane Griffin
2008-12-19 15:03               ` Duane Griffin
2008-12-19 19:28                 ` Andrew Morton
2008-12-19 19:43                 ` Al Viro
2008-12-16 16:38   ` Al Viro
2008-12-16 17:03 ` [PATCH 0/8, v3] ensure symlinks are NUL-terminated Dave Kleikamp
2008-12-16 17:26   ` Duane Griffin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1229442720-31056-1-git-send-email-duaneg@dghda.com \
    --to=duaneg@dghda.com \
    --cc=akpm@linux-foundation.org \
    --cc=dushistov@mail.ru \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).