From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Duane Griffin" Subject: [PATCH] sysv: ensure fast symlinks are NUL-terminated Date: Tue, 16 Dec 2008 15:51:59 +0000 Message-ID: <1229442720-31056-8-git-send-email-duaneg@dghda.com> References: <1229442720-31056-1-git-send-email-duaneg@dghda.com> <1229442720-31056-2-git-send-email-duaneg@dghda.com> <1229442720-31056-3-git-send-email-duaneg@dghda.com> <1229442720-31056-4-git-send-email-duaneg@dghda.com> <1229442720-31056-5-git-send-email-duaneg@dghda.com> <1229442720-31056-6-git-send-email-duaneg@dghda.com> <1229442720-31056-7-git-send-email-duaneg@dghda.com> Cc: linux-fsdevel@vger.kernel.org, Duane Griffin , Christoph Hellwig , Al Viro To: linux-kernel@vger.kernel.org Return-path: Received: from kumera.dghda.com ([80.68.90.171]:53454 "EHLO kumera.dghda.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757617AbYLPPwW (ORCPT ); Tue, 16 Dec 2008 10:52:22 -0500 In-Reply-To: <1229442720-31056-7-git-send-email-duaneg@dghda.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Ensure fast symlink targets are NUL-terminated, even if corrupted on-disk. Cc: Christoph Hellwig Cc: Al Viro Signed-off-by: Duane Griffin --- fs/sysv/inode.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/fs/sysv/inode.c b/fs/sysv/inode.c index df0d435..c93189d 100644 --- a/fs/sysv/inode.c +++ b/fs/sysv/inode.c @@ -27,6 +27,7 @@ #include #include #include +#include #include #include "sysv.h" @@ -163,8 +164,11 @@ void sysv_set_inode(struct inode *inode, dev_t rdev) if (inode->i_blocks) { inode->i_op = &sysv_symlink_inode_operations; inode->i_mapping->a_ops = &sysv_aops; - } else + } else { inode->i_op = &sysv_fast_symlink_inode_operations; + nd_terminate_link(SYSV_I(inode)->i_data, inode->i_size, + sizeof(SYSV_I(inode)->i_data)); + } } else init_special_inode(inode, inode->i_mode, rdev); } -- 1.6.0.4