* [PATCH, v4] vfs: introduce helper function to safely NUL-terminate symlinks
@ 2008-12-16 16:53 Duane Griffin
2008-12-16 16:53 ` [PATCH] " Duane Griffin
0 siblings, 1 reply; 2+ messages in thread
From: Duane Griffin @ 2008-12-16 16:53 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-fsdevel, Duane Griffin, Al Viro, Andrew Morton
A number of filesystems were potentially triggering kernel bugs due to
corrupted symlink names on disk. This helper helps safely terminate the
names.
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Duane Griffin <duaneg@dghda.com>
---
Version 4, this time with size_t instead of unsigned. Thanks Al!
include/linux/namei.h | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/include/linux/namei.h b/include/linux/namei.h
index 99eb803..231ce28 100644
--- a/include/linux/namei.h
+++ b/include/linux/namei.h
@@ -94,4 +94,9 @@ static inline char *nd_get_link(struct nameidata *nd)
return nd->saved_names[nd->depth];
}
+static inline void nd_terminate_link(void *name, size_t len, size_t maxlen)
+{
+ ((char *) name)[min(len, maxlen)] = '\0';
+}
+
#endif /* _LINUX_NAMEI_H */
--
1.6.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH] vfs: introduce helper function to safely NUL-terminate symlinks
2008-12-16 16:53 [PATCH, v4] vfs: introduce helper function to safely NUL-terminate symlinks Duane Griffin
@ 2008-12-16 16:53 ` Duane Griffin
0 siblings, 0 replies; 2+ messages in thread
From: Duane Griffin @ 2008-12-16 16:53 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-fsdevel, Duane Griffin, Al Viro, Andrew Morton
A number of filesystems were potentially triggering kernel bugs due to
corrupted symlink names on disk. This helper helps safely terminate the
names.
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Duane Griffin <duaneg@dghda.com>
---
include/linux/namei.h | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/include/linux/namei.h b/include/linux/namei.h
index 99eb803..231ce28 100644
--- a/include/linux/namei.h
+++ b/include/linux/namei.h
@@ -94,4 +94,9 @@ static inline char *nd_get_link(struct nameidata *nd)
return nd->saved_names[nd->depth];
}
+static inline void nd_terminate_link(void *name, size_t len, size_t maxlen)
+{
+ ((char *) name)[min(len, maxlen)] = '\0';
+}
+
#endif /* _LINUX_NAMEI_H */
--
1.6.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-12-16 16:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-16 16:53 [PATCH, v4] vfs: introduce helper function to safely NUL-terminate symlinks Duane Griffin
2008-12-16 16:53 ` [PATCH] " Duane Griffin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).