From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Duane Griffin" Subject: [PATCH, v5] 9p: don't print IS_ERR strings Date: Fri, 19 Dec 2008 20:47:09 +0000 Message-ID: <1229719638-6982-2-git-send-email-duaneg@dghda.com> References: <1229719638-6982-1-git-send-email-duaneg@dghda.com> Cc: linux-fsdevel@vger.kernel.org, Al Viro , Andrew Morton , Duane Griffin , Eric Van Hensbergen , Ron Minnich , Latchesar Ionkov , v9fs-developer@lists.sourceforge.net To: linux-kernel@vger.kernel.org Return-path: Received: from kumera.dghda.com ([80.68.90.171]:35259 "EHLO kumera.dghda.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751647AbYLSUr0 (ORCPT ); Fri, 19 Dec 2008 15:47:26 -0500 In-Reply-To: <1229719638-6982-1-git-send-email-duaneg@dghda.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Move the printk inside the !IS_ERR test. Cc: Eric Van Hensbergen Cc: Ron Minnich Cc: Latchesar Ionkov Cc: v9fs-developer@lists.sourceforge.net Signed-off-by: Duane Griffin --- Unchanged from original version. fs/9p/vfs_inode.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c index 8fddfe8..c50d555 100644 --- a/fs/9p/vfs_inode.c +++ b/fs/9p/vfs_inode.c @@ -1022,9 +1022,10 @@ v9fs_vfs_put_link(struct dentry *dentry, struct nameidata *nd, void *p) { char *s = nd_get_link(nd); - P9_DPRINTK(P9_DEBUG_VFS, " %s %s\n", dentry->d_name.name, s); - if (!IS_ERR(s)) + if (!IS_ERR(s)) { + P9_DPRINTK(P9_DEBUG_VFS, " %s %s\n", dentry->d_name.name, s); __putname(s); + } } /** -- 1.6.0.4