From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12C2FC001E0 for ; Fri, 21 Jul 2023 15:09:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231769AbjGUPJP (ORCPT ); Fri, 21 Jul 2023 11:09:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231791AbjGUPIv (ORCPT ); Fri, 21 Jul 2023 11:08:51 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C66630D7 for ; Fri, 21 Jul 2023 08:07:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689952073; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AtcGzkETEnO18qgeRoihrAkrVd5qbbNpgaZO4bjwaRo=; b=DNnTUCWPU2TZ3Xn8s6UOvF/8Zi65yekk2925WEcJiwqh8wHF1vlukAOECt1V9zBB61yEKN 899pWZo1o4spBOO1wGZNpUyNhbTjeo7S+45me8iZPHJuKMrNR9BFVL+lNl8ghW7Vqz9gPT i/tO6nUc5zQ74fFH77/WFFuT2igmTmQ= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-606-Y1yJtKnzMNGf1TU2gQvR4w-1; Fri, 21 Jul 2023 11:07:52 -0400 X-MC-Unique: Y1yJtKnzMNGf1TU2gQvR4w-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-4fb774de2d4so2062878e87.1 for ; Fri, 21 Jul 2023 08:07:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689952067; x=1690556867; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AtcGzkETEnO18qgeRoihrAkrVd5qbbNpgaZO4bjwaRo=; b=f0ihp0mX8aiJRzX7NTJvwUfomlVnb1SmSzfswlhijtXkVVYi/jKflej5vqBqy9M35N itfI9dT17JPQo4lfDerXHhLp6U6T5YIfh7xTApA0gmi+WlRcBjlcvF9eaaqtMIv6ORrO yQvhQRzyLsKku1DpTcsPKnlEZ5DAqA1jlYjXh29LprCT0pJh1/suoLMXn7iFt15q19DE KbvuB+CvFJ5HyKl6dCuk26N+xv5iNXdA96fp5WwaVOR5hIq266/EZlj7Pl2HZZQ685Hw r7DdtXnYo0huYIzCPvuwevR2QqqN3Od+zLmZSEfVfJipNbEqJi4r35Nhe8ithXgXdT1y /lSw== X-Gm-Message-State: ABy/qLYoEEAHq4gTMUSxX+R0SXWbijegYYGh875yICBV9VckjtJEE4Rw xGZp+iKPapc7K7DRLNBc92TdjouN/34XywZhnjctWrIMDadeAF9xkRZ3tkEiBSaNsV0LdgtvTO+ qIRZv0gYK7sUO+lAPmBkndijaHw== X-Received: by 2002:ac2:4191:0:b0:4f8:5ab0:68c4 with SMTP id z17-20020ac24191000000b004f85ab068c4mr1303839lfh.59.1689952067664; Fri, 21 Jul 2023 08:07:47 -0700 (PDT) X-Google-Smtp-Source: APBJJlGo8Pi+B+7hRHqSy6ClZ4oP94DPqHOZMbTIQ3rRFkaZiIFeWC2//bW1iNqq7vZ0rxNpIdgKag== X-Received: by 2002:ac2:4191:0:b0:4f8:5ab0:68c4 with SMTP id z17-20020ac24191000000b004f85ab068c4mr1303798lfh.59.1689952067306; Fri, 21 Jul 2023 08:07:47 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:9af8:e5f5:7516:fa89? ([2001:b07:6468:f312:9af8:e5f5:7516:fa89]) by smtp.googlemail.com with ESMTPSA id p1-20020a056402074100b0051df5eefa20sm2257329edy.76.2023.07.21.08.07.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Jul 2023 08:07:46 -0700 (PDT) Message-ID: <123035a3-9d0d-70be-9894-f89a84c7e8fd@redhat.com> Date: Fri, 21 Jul 2023 17:07:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [RFC PATCH v11 15/29] KVM: Drop superfluous __KVM_VCPU_MULTIPLE_ADDRESS_SPACE macro Content-Language: en-US To: Sean Christopherson , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Peng , Fuad Tabba , Jarkko Sakkinen , Yu Zhang , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , Vlastimil Babka , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" References: <20230718234512.1690985-1-seanjc@google.com> <20230718234512.1690985-16-seanjc@google.com> From: Paolo Bonzini In-Reply-To: <20230718234512.1690985-16-seanjc@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 7/19/23 01:44, Sean Christopherson wrote: > Signed-off-by: Sean Christopherson > --- > arch/x86/include/asm/kvm_host.h | 1 - > include/linux/kvm_host.h | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h > index b87ff7b601fa..7a905e033932 100644 > --- a/arch/x86/include/asm/kvm_host.h > +++ b/arch/x86/include/asm/kvm_host.h > @@ -2105,7 +2105,6 @@ enum { > #define HF_SMM_MASK (1 << 1) > #define HF_SMM_INSIDE_NMI_MASK (1 << 2) > > -# define __KVM_VCPU_MULTIPLE_ADDRESS_SPACE > # define KVM_ADDRESS_SPACE_NUM 2 > # define kvm_arch_vcpu_memslots_id(vcpu) ((vcpu)->arch.hflags & HF_SMM_MASK ? 1 : 0) > # define kvm_memslots_for_spte_role(kvm, role) __kvm_memslots(kvm, (role).smm) > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > index 0d1e2ee8ae7a..5839ef44e145 100644 > --- a/include/linux/kvm_host.h > +++ b/include/linux/kvm_host.h > @@ -693,7 +693,7 @@ bool kvm_arch_irqchip_in_kernel(struct kvm *kvm); > #define KVM_MEM_SLOTS_NUM SHRT_MAX > #define KVM_USER_MEM_SLOTS (KVM_MEM_SLOTS_NUM - KVM_INTERNAL_MEM_SLOTS) > > -#ifndef __KVM_VCPU_MULTIPLE_ADDRESS_SPACE > +#if KVM_ADDRESS_SPACE_NUM == 1 > static inline int kvm_arch_vcpu_memslots_id(struct kvm_vcpu *vcpu) > { > return 0; Reviewed-by: Paolo Bonzini