From: "Fernando Luis Vázquez Cao" <fernando@oss.ntt.co.jp>
To: Theodore Tso <tytso@mit.edu>
Cc: Christoph Hellwig <hch@infradead.org>,
Jeff Garzik <jeff@garzik.org>, Eric Sandeen <sandeen@redhat.com>,
Jan Kara <jack@suse.cz>, Alan Cox <alan@lxorguk.ukuu.org.uk>,
Pavel Machek <pavel@suse.cz>,
kernel list <linux-kernel@vger.kernel.org>,
Jens Axboe <jens.axboe@oracle.com>,
fernando@kic.ac.jp, Ric Wheeler <rwheeler@redhat.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: vfs: Add MS_FLUSHONFSYNC mount flag
Date: Mon, 16 Feb 2009 16:47:24 +0900 [thread overview]
Message-ID: <1234770444.32677.60.camel@sebastian.kern.oss.ntt.co.jp> (raw)
In-Reply-To: <20090215225427.GH10706@mini-me.lan>
On Sun, 2009-02-15 at 17:54 -0500, Theodore Tso wrote:
> On Sun, Feb 15, 2009 at 04:23:26PM +0900, Fernando Luis Vázquez Cao wrote:
> > You mentioned "we should integrate this with the barrier settings". Do
> > you imply we should make it a per-device tunable too? Should we keep the
> > barrier-related mount options some filesystems provide?
> >
>
> Making barriers to be a per-device tunable makes sense. The only
> reason why we kept it as a mount option in ext4 is for benchmarking
> purposes, and in ext3, because the filesystem predated the barrier
> code, and there was a desire to be able to benchmark with and without
> the old behavior --- and because akpm is still worried about the
> performance hit of the barrier code, so he's been resistant about
> change the default for ext3.
Ok, I'll turn both barriers and flushonfsync into a sysfs-exported
per-device knob and see how it turns out.
By the way, should we also add/keep a mount option for "benchmarking
purposes"?. I guess that once we get the per-device tunable we probable
do not need it anymore.
Regards,
Fernando
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2009-02-16 7:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1232109069.13775.35.camel@sebastian.kern.oss.ntt.co.jp>
[not found] ` <1232114101.13775.63.camel@sebastian.kern.oss.ntt.co.jp>
[not found] ` <20090116163039.GE10617@duck.suse.cz>
[not found] ` <1232185639.4831.18.camel@sebastian.kern.oss.ntt.co.jp>
[not found] ` <1232186449.4831.29.camel@sebastian.kern.oss.ntt.co.jp>
[not found] ` <20090119120349.GA10193@duck.suse.cz>
[not found] ` <1233135913.5399.57.camel@sebastian.kern.oss.ntt.co.jp>
[not found] ` <20090128095518.GA16554@duck.suse.cz>
[not found] ` <1234434811.15270.7.camel@sebastian.kern.oss.ntt.co.jp>
[not found] ` <1234435245.15433.19.camel@sebastian.kern.oss.ntt.co.jp>
[not found] ` <20090215224659.GG10706@mini-me.lan>
[not found] ` <1234768181.32677.7.camel@sebastian.kern.oss.ntt.co.jp>
2009-02-16 7:25 ` [PATCH 1/3] block: Add block_flush_device() Fernando Luis Vázquez Cao
2009-02-16 7:29 ` [2/3] ext3: call block_flush_device() on fsync Fernando Luis Vázquez Cao
2009-02-16 7:31 ` [PATCH 3/3] ext4: " Fernando Luis Vázquez Cao
[not found] ` <1234434970.15433.4.camel@sebastian.kern.oss.ntt.co.jp>
[not found] ` <499458C1.90105@redhat.com>
[not found] ` <49945C90.3010104@garzik.org>
[not found] ` <20090214153626.GA3973@infradead.org>
[not found] ` <1234682606.19783.222.camel@sebastian.kern.oss.ntt.co.jp>
[not found] ` <20090215225427.GH10706@mini-me.lan>
2009-02-16 7:47 ` Fernando Luis Vázquez Cao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1234770444.32677.60.camel@sebastian.kern.oss.ntt.co.jp \
--to=fernando@oss.ntt.co.jp \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=fernando@kic.ac.jp \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=jeff@garzik.org \
--cc=jens.axboe@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=rwheeler@redhat.com \
--cc=sandeen@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).