From: Peter Zijlstra <peterz@infradead.org>
To: Nick Piggin <npiggin@suse.de>
Cc: linux-fsdevel@vger.kernel.org,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [patch][rfc] mm: hold page lock over page_mkwrite
Date: Thu, 26 Feb 2009 10:20:18 +0100 [thread overview]
Message-ID: <1235640018.4645.4692.camel@laptop> (raw)
In-Reply-To: <20090225093629.GD22785@wotan.suse.de>
On Wed, 2009-02-25 at 10:36 +0100, Nick Piggin wrote:
> + if (!page_mkwrite)
> + wait_on_page_locked(dirty_page);
> set_page_dirty_balance(dirty_page, page_mkwrite);
> put_page(dirty_page);
> + if (page_mkwrite) {
> + unlock_page(old_page);
> + page_cache_release(old_page);
> + }
We're calling into the whole balance_dirty_pages() writeout path with a
page locked.. is that sensible?
next prev parent reply other threads:[~2009-02-26 9:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 9:36 [patch][rfc] mm: hold page lock over page_mkwrite Nick Piggin
2009-02-25 16:42 ` Zach Brown
2009-02-25 16:55 ` Nick Piggin
2009-02-25 16:58 ` Zach Brown
2009-02-25 17:02 ` Nick Piggin
2009-02-25 22:35 ` Mark Fasheh
2009-02-25 16:48 ` Chris Mason
2009-02-26 9:20 ` Peter Zijlstra [this message]
2009-02-26 11:09 ` Nick Piggin
2009-03-01 8:17 ` Dave Chinner
2009-03-01 13:50 ` Nick Piggin
2009-03-02 8:19 ` Dave Chinner
2009-03-02 8:37 ` Nick Piggin
2009-03-02 15:26 ` jim owens
2009-03-03 4:33 ` Nick Piggin
2009-03-03 17:25 ` Jamie Lokier
2009-03-04 4:37 ` Dave Chinner
2009-03-04 9:23 ` Nick Piggin
2009-03-04 18:13 ` Jamie Lokier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1235640018.4645.4692.camel@laptop \
--to=peterz@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).