From: Chris Mason <chris.mason@oracle.com>
To: Kyle McMartin <kyle@mcmartin.ca>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] btrfs: fix __ucmpdi2 compile bug on 32 bit builds
Date: Fri, 27 Mar 2009 10:37:44 -0400 [thread overview]
Message-ID: <1238164664.27455.8.camel@think.oraclecorp.com> (raw)
In-Reply-To: <20090327142401.GA29999@bombadil.infradead.org>
On Fri, 2009-03-27 at 10:24 -0400, Kyle McMartin wrote:
> On Sat, Mar 28, 2009 at 01:16:26AM +1100, Stephen Rothwell wrote:
> > > - switch (em->block_start) {
> > > - case EXTENT_MAP_LAST_BYTE:
> > > + if (em->block_start == EXTENT_MAP_LAST_BYTE) {
> >
> > I might be a good idea to put a comment there about why this isn't a
> > switch statement so that someone doesn't "clean up" this code in the
> > future.
> >
>
> nrrrgh. Remind me why we can't just add the libgcc helpers?
>
> Unless we plan on growing some more of these, surely we can just reduce
> it to a u32 for the switch...
EXTENT_MAP_LAST_BYTE is something like (u64)-5
This if/else setup is fine, I'll take the patch.
-chris
next prev parent reply other threads:[~2009-03-27 14:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-27 12:42 [PATCH] btrfs: fix __ucmpdi2 compile bug on 32 bit builds Heiko Carstens
2009-03-27 14:16 ` Stephen Rothwell
2009-03-27 14:24 ` Kyle McMartin
2009-03-27 14:37 ` Chris Mason [this message]
2009-03-28 9:38 ` Andi Kleen
2009-03-29 19:22 ` Kyle McMartin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1238164664.27455.8.camel@think.oraclecorp.com \
--to=chris.mason@oracle.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kyle@mcmartin.ca \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).